Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement graceful shutdown and propagate request context #468

Merged
merged 10 commits into from Apr 4, 2020
Merged

Implement graceful shutdown and propagate request context #468

merged 10 commits into from Apr 4, 2020

Commits on Apr 4, 2020

  1. feature: Implement graceful shutdown 

    Propagate the request context to the Redis client.
It is possible to propagate a context cancel to Redis client if the connection is closed by the HTTP client.
The redis.Cmdable cannot use WithContext, so added the Client interface to handle redis.Client and redis.ClusterClient transparently.

Added handling of Unix signals to http server.

Upgrade go-redis/redis to v7.
    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    f4be1a1 View commit details
    Browse the repository at this point in the history

  2. Update dependencies 

    - Upgrade golang/x/* and google-api-go
- Migrate fsnotify import from gopkg.in to github.com
- Replace bmizerany/assert with stretchr/testify/assert
    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    0d81995 View commit details
    Browse the repository at this point in the history

  3. add doc for wrapper interface

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    21e7f60 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    686756f View commit details
    Browse the repository at this point in the history

  5. fix: upgrade fsnotify to v1.4.9

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    c28a948 View commit details
    Browse the repository at this point in the history

  6. fix: remove unnessary logging

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    610ec12 View commit details
    Browse the repository at this point in the history

  7. fix: wait until all connections have been closed

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    a4e531a View commit details
    Browse the repository at this point in the history

  8. refactor: move chan to main for testing

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    44ed2ff View commit details
    Browse the repository at this point in the history

  9. add assert to check if stop chan is empty

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    7c2ea54 View commit details
    Browse the repository at this point in the history

  10. add an idiomatic for sync.WaitGroup with timeout

    @johejo
    johejo committed Apr 4, 2020
    Configuration menu
    Copy the full SHA
    b620f6e View commit details
    Browse the repository at this point in the history