Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarking utilities #2687

Merged
merged 6 commits into from Apr 30, 2020
Merged

benchmarking utilities #2687

merged 6 commits into from Apr 30, 2020

Conversation

matevz
Copy link
Member

@matevz matevz commented Feb 17, 2020 •
edited

@codecov
Copy link

codecov bot commented Feb 18, 2020 •
edited

Codecov Report

Merging #2687 into master will decrease coverage by 0.12%.
The diff coverage is 53.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
- Coverage   67.69%   67.57%   -0.13%     
==========================================
  Files         344      349       +5     
  Lines       33652    33821     +169     
==========================================
+ Hits        22782    22854      +72     
- Misses       7939     8039     +100     
+ Partials     2931     2928       -3
Impacted Files Coverage Δ
go/common/version/version.go 84.00% <ø> (ø)
go/oasis-node/cmd/common/logging.go 58.06% <0.00%> (-9.68%) ⬇️
go/oasis-node/cmd/common/pprof/pprof.go 26.66% <0.00%> (-6.67%) ⬇️
go/oasis-node/cmd/common/metrics/metrics.go 16.66% <15.68%> (-2.43%) ⬇️
go/oasis-node/cmd/common/flags/flags.go 82.00% <41.66%> (-12.74%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <65.51%> (ø)
go/oasis-node/cmd/common/metrics/cpu.go 68.42% <68.42%> (ø)
go/oasis-node/cmd/common/metrics/mem.go 71.42% <71.42%> (ø)
go/oasis-node/cmd/common/metrics/net.go 71.42% <71.42%> (ø)
go/oasis-node/cmd/common/metrics/resource.go 92.00% <92.00%> (ø)
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 031766e...903eef1. Read the comment docs.

@matevz matevz force-pushed the matevz/feature/bench branch 2 times, most recently from 80d946a to 2bee609 Compare February 25, 2020 13:26
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #2687 into master will decrease coverage by 1.61%.
The diff coverage is 22.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
- Coverage   63.12%   61.51%   -1.62%     
==========================================
  Files         378      379       +1     
  Lines       35532    35816     +284     
==========================================
- Hits        22431    22033     -398     
- Misses      10273    11043     +770     
+ Partials     2828     2740      -88
Impacted Files Coverage Δ
go/oasis-test-runner/oasis/oasis.go 0% <ø> (ø) ⬆️
go/oasis-node/cmd/storage/benchmark/benchmark.go 3.9% <0%> (-0.02%) ⬇️
go/worker/compute/txnscheduler/service.go 40% <100%> (+10.58%) ⬆️
go/storage/mkvs/urkel/commit.go 72.11% <100%> (+0.27%) ⬆️
go/oasis-node/cmd/common/metrics/metrics.go 19.09% <100%> (ø) ⬆️
go/oasis-test-runner/cmd/root.go 12.16% <12.67%> (ø)
go/oasis-node/cmd/common/pprof/pprof.go 46.87% <87.5%> (+13.54%) ⬆️
go/oasis-node/cmd/stake/stake.go 14.52% <0%> (-57.27%) ⬇️
go/worker/storage/service_internal.go 0% <0%> (-53.34%) ⬇️
go/worker/storage/committee/checkpointer.go 27.43% <0%> (-40.71%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2616c3c...74b8b07. Read the comment docs.

@matevz matevz force-pushed the matevz/feature/bench branch 2 times, most recently from 9c96909 to 0cc49de Compare February 27, 2020 15:32
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@470bbd3). Click here to learn what that means.
The diff coverage is 21.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2687   +/-   ##
=========================================
  Coverage          ?   62.52%           
=========================================
  Files             ?      379           
  Lines             ?    35844           
  Branches          ?        0           
=========================================
  Hits              ?    22412           
  Misses            ?    10636           
  Partials          ?     2796
Impacted Files Coverage Δ
go/oasis-test-runner/oasis/args.go 0% <0%> (ø)
go/oasis-node/cmd/storage/benchmark/benchmark.go 3.9% <0%> (ø)
go/oasis-test-runner/oasis/oasis.go 0% <0%> (ø)
go/worker/compute/txnscheduler/service.go 40% <100%> (ø)
go/storage/mkvs/urkel/commit.go 72.11% <100%> (ø)
go/oasis-test-runner/cmd/root.go 13.15% <14.48%> (ø)
go/oasis-node/cmd/common/metrics/metrics.go 17.21% <18.91%> (ø)
go/oasis-node/cmd/common/pprof/pprof.go 46.87% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470bbd3...0cc49de. Read the comment docs.

Yawning
Yawning previously requested changes Mar 4, 2020
View reviewed changes
go/oasis-node/cmd/common/metrics/metrics.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/common/metrics/metrics.go Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/bench branch 2 times, most recently from 670d53d to 424753e Compare March 6, 2020 09:46
@matevz matevz force-pushed the matevz/feature/bench branch 3 times, most recently from 80ce59f to 3db6ec4 Compare March 19, 2020 14:44
@matevz matevz force-pushed the matevz/feature/bench branch 3 times, most recently from 19a853e to a6d9a17 Compare March 26, 2020 15:19
@matevz matevz marked this pull request as ready for review March 26, 2020 16:02
@matevz matevz force-pushed the matevz/feature/bench branch 2 times, most recently from 74c307f to 8faf335 Compare March 26, 2020 16:07
@matevz matevz added c:performance Category: performance c:testing Category: testing labels Mar 26, 2020
@matevz matevz self-assigned this Mar 26, 2020
@matevz matevz requested a review from Yawning March 26, 2020 16:11
kostko
kostko reviewed Apr 23, 2020
View reviewed changes
go/oasis-net-runner/cmd/root.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Show resolved Hide resolved
kostko
kostko requested changes Apr 23, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not start using abstract sockets everywhere. They should be for E2E tests ONLY, gated behind a don't blame oasis flag.

go/extra/stats/README.md Outdated Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/bench branch 3 times, most recently from 1ecc181 to 418a63e Compare April 28, 2020 08:38
kostko
kostko reviewed Apr 28, 2020
View reviewed changes
go/oasis-node/cmd/common/grpc/grpc.go Outdated Show resolved Hide resolved
go/oasis-test-runner/cmd/root.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/byzantine.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Show resolved Hide resolved
@matevz matevz force-pushed the matevz/feature/bench branch 8 times, most recently from 85ec3b7 to ba856fb Compare April 29, 2020 09:37
kostko
kostko reviewed Apr 29, 2020
View reviewed changes
.changelog/2687.internal.3.md Outdated Show resolved Hide resolved
go/oasis-node/cmd/common/grpc/grpc.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/common/grpc/grpc.go Show resolved Hide resolved
go/oasis-node/cmd/common/grpc/grpc.go Show resolved Hide resolved
go/oasis-test-runner/oasis/args.go Outdated Show resolved Hide resolved
go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/halt_restore.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/runtime.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/txsource.go Outdated Show resolved Hide resolved
go/oasis-test-runner/scenario/scenario.go Show resolved Hide resolved
@matevz matevz merged commit 40119d9 into master Apr 30, 2020
@matevz matevz deleted the matevz/feature/bench branch April 30, 2020 12:00
@kostko kostko mentioned this pull request May 2, 2020
Merged
@matevz matevz mentioned this pull request May 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjgilbert peterjgilbert peterjgilbert left review comments

@ptrus ptrus ptrus left review comments

@kostko kostko kostko approved these changes

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees

@matevz matevz

Labels
c:breaking/cfg Category: breaks configuration c:performance Category: performance c:testing Category: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

measure disk, IO, memory and CPU usage in oasis-test-runner
6 participants
@matevz @pro-wh @kostko @peterjgilbert @Yawning @ptrus