Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on browser warnings #380

Merged
merged 18 commits into from Aug 6, 2021
Merged

Work on browser warnings #380

merged 18 commits into from Aug 6, 2021

Conversation

epugh
Copy link
Member

@epugh epugh commented Jun 12, 2021

Description

remove unused css

Motivation and Context

firefox warns on unneeded css

How Has This Been Tested?

manually

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

epugh@opensourceconnections.com added 2 commits June 11, 2021 18:47
@epugh epugh temporarily deployed to quepid-pr-380 June 12, 2021 12:27 Inactive
@epugh
Copy link
Member Author

epugh commented Aug 2, 2021

So, turns out one of our gems may be part of the issue! MiniProfiler/rack-mini-profiler#504. Going to do a PR!

@epugh epugh temporarily deployed to quepid-pr-380 August 4, 2021 16:01 Inactive
@epugh epugh merged commit ebfbc3e into master Aug 6, 2021
@epugh epugh deleted the work_on_browser_warnings branch January 8, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant