Skip to content

Commit

Permalink
Work on browser warnings (#380)
Browse files Browse the repository at this point in the history
* bump dev tool

* start pruning

* pending MiniProfiler/rack-mini-profiler#505 being merged and committed, this removes some warnings

* removing console warnings in FF about stylesheet issues

* remove alpha warnings

* we have fixes for miniprofiler

* needed for reference git repo as gem

* we should use sessions/new instead of /sessions when we create a new session!

* lint

* fix tests

* lint

* ignore resize, we dont seem to use it

* and remove it

* one more reference

* one more place we had index instead of new

* remove commented out code

* specify the path to favicon, avoiding console message about missing favicon

Co-authored-by: epugh@opensourceconnections.com <>
  • Loading branch information
epugh committed Aug 6, 2021
1 parent 77b272c commit ebfbc3e
Show file tree
Hide file tree
Showing 19 changed files with 32 additions and 300 deletions.
4 changes: 3 additions & 1 deletion Gemfile
Expand Up @@ -43,7 +43,9 @@ group :development, :test do
gem 'bullet'
gem 'byebug'
gem 'memory_profiler'
gem 'rack-mini-profiler'
# rubocop:disable Layout/LineLength
gem 'rack-mini-profiler', git: 'https://github.com/MiniProfiler/rack-mini-profiler' # pending release with PR 505 included
# rubocop:enable Layout/LineLength
end

group :development do
Expand Down
11 changes: 8 additions & 3 deletions Gemfile.lock
@@ -1,3 +1,10 @@
GIT
remote: https://github.com/MiniProfiler/rack-mini-profiler
revision: 4e6d463b03a6979037171ae2866a85e11fc344df
specs:
rack-mini-profiler (2.3.2)
rack (>= 1.2.0)

GEM
remote: https://rubygems.org/
specs:
Expand Down Expand Up @@ -253,8 +260,6 @@ GEM
rack (2.2.3)
rack-cors (1.1.1)
rack (>= 2.0.0)
rack-mini-profiler (2.3.2)
rack (>= 1.2.0)
rack-protection (2.1.0)
rack
rack-proxy (0.7.0)
Expand Down Expand Up @@ -421,7 +426,7 @@ DEPENDENCIES
puma_worker_killer
pundit
rack-cors (~> 1.1)
rack-mini-profiler
rack-mini-profiler!
rails (= 6.1.4)
rails-controller-testing
rails-erd (~> 1.6)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Expand Up @@ -331,7 +331,7 @@ bin/docker r bin/rake db:seed
bin/docker r bin/rake db:setup
# show routes
bin/docker r bin/rake routes
bin/docker r bin/rails routes
# tests
bin/docker r bin/rake test
Expand Down
14 changes: 4 additions & 10 deletions app/assets/stylesheets/_qgraph.scss
Expand Up @@ -14,11 +14,11 @@ qgraph {
fill: none;
stroke-linecap: round;
}

.axis {
shape-rendering: crispEdges;
}

.x.axis line {
stroke: lightgrey;
}
Expand All @@ -32,25 +32,21 @@ qgraph {
fill: none;
stroke: #000;
}

line.marker {
stroke: blue;
stroke-width: 4;
stroke-linecap: round;
stroke-opacity: 0.3;
}

.qtip {
position: absolute;
width: 200px;
height: auto;
padding: 10px;
background-color: white;
-webkit-border-radius: 10px;
-moz-border-radius: 10px;
border-radius: 10px;
-webkit-box-shadow: 4px 4px 10px rgba(0, 0, 0, 0.4);
-moz-box-shadow: 4px 4px 10px rgba(0, 0, 0, 0.4);
box-shadow: 4px 4px 10px rgba(0, 0, 0, 0.4);
pointer-events: none;

Expand Down Expand Up @@ -122,5 +118,3 @@ qgraph {
top: 50%;
left: 100%;
}


12 changes: 0 additions & 12 deletions app/assets/stylesheets/bootstrap-add.css
Expand Up @@ -112,9 +112,6 @@ a, button, .button {
background: -moz-linear-gradient(top, #FFFFFF, #F0F0F0);
border: none;
border-radius: 0;
-moz-border-radius: 0;
-webkit-border-radius: 0;
-khtml-border-radius: 0;
margin-bottom: 0;
}

Expand Down Expand Up @@ -421,9 +418,6 @@ header .dropdown-content li.dropdown-header {
right: 19px;
font-weight: bold;
border-radius: 3px;
-moz-border-radius: 3px;
-webkit-border-radius: 3px;
-khtml-border-radius: 3px;
font-size: 16px;
}

Expand Down Expand Up @@ -757,13 +751,7 @@ header .dropdown-content li.dropdown-header {
color: #FFF;
border: none;
border-bottom-left-radius: 3px;
-moz-border-bottom-left-radius: 3px;
-webkit-border-bottom-left-radius: 3px;
-khtml-border-bottom-left-radius: 3px;
border-bottom-right-radius: 3px;
-moz-border-bottom-right-radius: 3px;
-webkit-border-bottom-right-radius: 3px;
-khtml-border-bottom-right-radius: 3px;
}

#dev-settings .btn-submit {
Expand Down
42 changes: 3 additions & 39 deletions app/assets/stylesheets/bootstrap.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion app/assets/stylesheets/home.css.scss
Expand Up @@ -22,7 +22,7 @@

@import "fonts";
@import "panes";
@import "resize";
//@import "resize"; # this file here is a candidate for deleting, appears we don't use it.
@import "stackedChart";
@import "bootstrap-add";
@import "base";
Expand Down

0 comments on commit ebfbc3e

Please sign in to comment.