New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rubocop and add Style/MutableConstant #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,18 +35,52 @@ Lint: | |
Lint/AmbiguousBlockAssociation: | ||
Exclude: | ||
- spec/**/* | ||
Lint/BinaryOperatorWithIdenticalOperands: | ||
Enabled: true | ||
Lint/ConstantDefinitionInBlock: | ||
Enabled: true | ||
Lint/DeprecatedOpenSSLConstant: | ||
Enabled: true | ||
Lint/DuplicateElsifCondition: | ||
Enabled: true | ||
Lint/DuplicateRequire: | ||
Enabled: true | ||
Lint/DuplicateRescueException: | ||
Enabled: true | ||
Lint/EmptyConditionalBody: | ||
Enabled: true | ||
Lint/EmptyFile: | ||
Enabled: true | ||
Lint/FloatComparison: | ||
Enabled: true | ||
Lint/IdentityComparison: | ||
Enabled: true | ||
Lint/Loop: | ||
Enabled: false | ||
Lint/MissingSuper: | ||
Enabled: true | ||
Lint/MixedRegexpCaptureTypes: | ||
Enabled: true | ||
Lint/OutOfRangeRegexpRef: | ||
Enabled: true | ||
Lint/RaiseException: | ||
Enabled: true | ||
Lint/SelfAssignment: | ||
Enabled: true | ||
Lint/StructNewOverride: | ||
Enabled: true | ||
Lint/TopLevelReturnWithArgument: | ||
Enabled: true | ||
Lint/TrailingCommaInAttributeDeclaration: | ||
Enabled: true | ||
Comment on lines
+74
to
+75
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If this does what I think, then we don't want it (because we don't want trailing commas). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It does this https://docs.rubocop.org/rubocop/0.90/cops_lint.html#linttrailingcommainattributedeclaration We want it |
||
Lint/UnreachableLoop: | ||
Enabled: true | ||
Lint/UselessMethodDefinition: | ||
Enabled: true | ||
Lint/UselessTimes: | ||
Enabled: true | ||
Style/MutableConstant: | ||
Enabled: true | ||
Style/StringLiterals: | ||
Enabled: true | ||
Style/SymbolArray: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
module NxtCop | ||
VERSION = '1.0.6'.freeze | ||
VERSION = '1.0.7'.freeze | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubocop/rubocop#7425