Update rubocop and add Style/MutableConstant

[the-wendell]

No description provided.

[nsommer]

If this does what I think, then we don't want it (because we don't want trailing commas).

[the-wendell]

It does this

https://docs.rubocop.org/rubocop/0.90/cops_lint.html#linttrailingcommainattributedeclaration

We want it

[nsommer]

What does this mean?

[the-wendell]

rubocop/rubocop#7425

[nsommer]

Do we really want to add all new cops? We initially said we want to keep the config lean and not include stuff by default, which I really liked. I don't even understand half of the cops added without looking them up.

[the-wendell]

Do we really want to add all new cops? We initially said we want to keep the config lean and not include stuff by default, which I really liked. I don't even understand half of the cops added without looking them up.

Classic Nils!!

Anyways... all the cops that are Lint/ we 100% want. They do not check for style but for runtime errors and valid code. The Lint cops actually caught a few bugs in insurance service and payment service when I first added rubocop.

[nsommer]

Anyways... all the cops that are Lint/ we 100% want.

Makes total sense, I didn't realize those are all lint comments ...