Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): normalize devtool for terser compatibility #6566

Merged
merged 5 commits into from Oct 19, 2019
Merged

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Oct 14, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Some modules are using #source-map as devtool, this pr is for supporting those modules usage.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from aldarund and pi0 October 14, 2019 21:51
@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #6566 into dev will decrease coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #6566      +/-   ##
==========================================
- Coverage   95.85%   95.82%   -0.04%     
==========================================
  Files          78       78              
  Lines        2705     2709       +4     
  Branches      699      700       +1     
==========================================
+ Hits         2593     2596       +3     
- Misses         97       98       +1     
  Partials       15       15
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.71% <66.66%> (-0.03%) ⬇️
#unit 92.32% <66.66%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 90.47% <66.66%> (-1.61%) ⬇️
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6589c...51e3ee4. Read the comment docs.

@clarkdo clarkdo requested review from pi0 and aldarund and removed request for aldarund October 17, 2019 20:40
@pi0 pi0 changed the title fix: #source-map not work in terser plugin fix(webpack): normalize devtool for terser compatibility Oct 19, 2019
@pi0 pi0 merged commit 8391753 into dev Oct 19, 2019
@pi0 pi0 deleted the terser-sourcemap branch October 19, 2019 08:21
@pi0 pi0 mentioned this pull request Oct 21, 2019
@pi0 pi0 mentioned this pull request Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants