Skip to content

Commit

Permalink
fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
clarkdo committed Oct 17, 2019
1 parent 10d8dad commit ec48c52
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/fixtures/with-config/nuxt.config.js
Expand Up @@ -86,7 +86,7 @@ export default {
transpile: 'vue-test',
extend (config, options) {
return Object.assign({}, config, {
devtool: '#source-map'
devtool: 'source-map'

This comment has been minimized.

Copy link
@rchl

rchl Oct 17, 2019

Why did the test fail? Shouldn't it pass since you've added code to normalize those values?
Would it make sense to also have a test that tests that value with # still works?

This comment has been minimized.

Copy link
@clarkdo

clarkdo Oct 17, 2019

Author Member

It failed because of warning assertions

This comment has been minimized.

Copy link
@clarkdo

clarkdo Oct 17, 2019

Author Member

webpack5 will only accept documented devtool values, so this process will be removed in webpack5 release, I think we can keep it like this since it’s a short term and simple change. And it also provides a correct demonstration if someone reads the fixture as example.

})
}
},
Expand Down

0 comments on commit ec48c52

Please sign in to comment.