Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.10.2 #6601

Merged
merged 21 commits into from Oct 21, 2019
Merged

v2.10.2 #6601

merged 21 commits into from Oct 21, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Oct 21, 2019

🐛 Bug Fixes

📝 Examples

💖 Thanks to

@pi0 pi0 requested a review from a team October 21, 2019 09:16
@kevinmarrec
Copy link
Contributor

Tests failing ?

@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #6601 into 2.x will decrease coverage by 0.06%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #6601      +/-   ##
==========================================
- Coverage   95.85%   95.79%   -0.07%     
==========================================
  Files          78       78              
  Lines        2705     2713       +8     
  Branches      699      702       +3     
==========================================
+ Hits         2593     2599       +6     
- Misses         97       99       +2     
  Partials       15       15
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 64.65% <50%> (-0.09%) ⬇️
#unit 92.29% <83.33%> (-0.02%) ⬇️
Impacted Files Coverage Δ
packages/webpack/src/config/client.js 98.11% <100%> (+0.03%) ⬆️
packages/vue-renderer/src/renderers/ssr.js 94.02% <100%> (ø) ⬆️
packages/config/src/options.js 100% <100%> (ø) ⬆️
packages/webpack/src/config/base.js 90.38% <66.66%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624c4c0...437af14. Read the comment docs.

@pi0
Copy link
Member Author

pi0 commented Oct 21, 2019

@kevinmarrec seems random

@kevinmarrec
Copy link
Contributor

😆

@Atinux Atinux self-requested a review October 21, 2019 09:27
Copy link

@pimlie pimlie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clarkdo Although others and me already approved #6495 itself, the opening post in that PR still list a todo about checking memory usage in dev mode.

Before we release 6495, could you please confirm the status of that todo?

@clarkdo
Copy link
Member

clarkdo commented Oct 21, 2019

Will do it tonight

@clarkdo
Copy link
Member

clarkdo commented Oct 21, 2019

Verified in my local with hot reloading, restarting and ssr benchmark.

@pi0 pi0 merged commit f6aa45d into 2.x Oct 21, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet