This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt): don't override payload error if it is present #7290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
✅ Deploy Preview for nuxt3-docs canceled.
|
pi0
approved these changes
Sep 6, 2022
|
The upstream bug has been fixed in Vue 3.2.29, for anyone tracking it. 🥳 confirmed in #7321. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves nuxt/nuxt#14695
❓ Type of change
📚 Description
Currently if a renderering error occurs after another error the rendering error will take precedence. (e.g. if an error is thrown in
<script setup>). This PR simply ensures that the original error is the one we handle.I've moved the test case to the end of the file as vuejs/core#6110 means that the dev test fixture is broken after a rendering error. We either need to work around it in a separate PR or 🤞 that it is resolved upstream. (But either way, the issue already exists apart from this PR.)
📝 Checklist