Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 965: Special build using pre-release of nunit.engine 4.0.0 #966

Closed
wants to merge 2 commits into from

Conversation

manfred-brands
Copy link
Member

Fixes #965

I left this as a draft PR as I don't expect it to be merged into master.
The purpose is to get a special build that can be referenced in nunit framework nunit4 developments.

As I also not aware of the changes in the engine, I have deleted several lines in TestAdapterUtils as those classes no longer exist.

There was one other change. The name/fullname properties of the test-run node seem to no longer exist.

I testes the nuget package with nunit framework and it allows me to run tests in VS and with dotnet test

@manfred-brands
Copy link
Member Author

Not sure if you agree with the version number, but the adapter seems to be one ahead of the engine/framework.

@manfred-brands
Copy link
Member Author

The build seem to not be able to find the myget package when referenced in .csproj file. Trying to add to nuget.config

@manfred-brands
Copy link
Member Author

@CharliePoole The engine does find the test for netcore/net6, but not for net framework.
In the debugger is shows:

System.ComponentModel.Win32Exception : The system cannot find the file specified--Win32Exception
The system cannot find the file specified
   at System.Diagnostics.Process.StartWithCreateProcess(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at NUnit.Engine.Services.TestAgency.GetAgent(TestPackage package)
   at NUnit.Engine.Runners.ProcessRunner.CreateAgentAndRunnerIfNeeded()
   at NUnit.Engine.Runners.ProcessRunner.Explore(TestFilter filter)

It seems to be looking for nunit-agent.exe binaries. I see them in the contentFiles directory.

@OsirisTerje build.cake --target=Test shows all green lines, even though it didn't find any tests.

No test is available in D:\3rd\NUnit\nunit3-vs-adapter\src\NUnitTestAdapterTests\bin\Debug\net46\NUnit.VisualStudio.TestAdapter.Tests.dll. Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again.

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a major version change, so 4.3.0 is sufficient. Also, add pre-release for now, so e.g. 4.3.0-beta.1 should do it. And you're right, the version numbers are not aligned across components, and that is "By design". :-)

@CharliePoole
Copy link
Contributor

@manfred-brands My guess is that you are running into nunit/nunit-console#1023, which is a pretty big one!

I just assigned you an issue, which is a small part of a bigger part of that issue. :-)

@OsirisTerje
Copy link
Member

I assume we don't need this anymore, as 4.5 does run nunit 4.

@OsirisTerje OsirisTerje closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create (beta) version that can be used in NUnit4 development
3 participants