BUG: make a variable volatile to work around clang compiler bug #18030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @r-devulap this sounds like a simple and good change to me. Should be backported to both 1.19.x and 1.20.x I guess. @tomgoddard I trust this fixes the issue, but if it is easy for you to check, that would be appreciated! |
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 19, 2020
…y#18030) * BUG: make a variable volatile to work around clang compiler bug * Adding comments for relevance * TST: Adding test to check for no overflow warnings in log Fixes numpy#18005
charris
pushed a commit
to charris/numpy
that referenced
this pull request
Dec 19, 2020
…y#18030) * BUG: make a variable volatile to work around clang compiler bug * Adding comments for relevance * TST: Adding test to check for no overflow warnings in log Fixes numpy#18005
charris
added
component: build
and removed
09 - Backport-Candidate
|
I tried today's numpy daily build numpy-1.21.0.dev0+271.gf7bc51218-cp38-cp38-macosx_10_9_x86_64.whl in my software that led to this bug report and no longer get the log() overflow warning. I did not verify that this daily build has the patch.
Thanks for the amazing quick work to locate and fix the problem. I find it interesting that this bug could go unreported for long. Surely log(float32) is used a fair bit. Maybe it indicates that the RuntimeWarning messages are largely suppressed by software that uses numpy.
|
|
@tomgoddard The fix was included in that build. |
|
Relatively speaking, not too many people are affected by this or would notice it, I think.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18005