Skip to content

Commit

Permalink
BUG: make a variable volatile to work around clang compiler bug (#18030)
Browse files Browse the repository at this point in the history
* BUG: make a variable volatile to work around clang compiler bug

* Adding comments for relevance

* TST: Adding test to check for no overflow warnings in log

Fixes #18005
  • Loading branch information
r-devulap committed Dec 19, 2020
1 parent b2f29f2 commit dc3fe03
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 2 deletions.
12 changes: 10 additions & 2 deletions numpy/core/src/umath/simd.inc.src
Expand Up @@ -1549,7 +1549,11 @@ fma_get_exponent(__m256 x)
__m256 denormal_mask = _mm256_cmp_ps(x, _mm256_set1_ps(FLT_MIN), _CMP_LT_OQ);
__m256 normal_mask = _mm256_cmp_ps(x, _mm256_set1_ps(FLT_MIN), _CMP_GE_OQ);

__m256 temp1 = _mm256_blendv_ps(x, _mm256_set1_ps(0.0f), normal_mask);
/*
* It is necessary for temp1 to be volatile, a bug in clang optimizes it out which leads
* to an overflow warning in some cases. See https://github.com/numpy/numpy/issues/18005
*/
volatile __m256 temp1 = _mm256_blendv_ps(x, _mm256_set1_ps(0.0f), normal_mask);
__m256 temp = _mm256_mul_ps(temp1, two_power_100);
x = _mm256_blendv_ps(x, temp, denormal_mask);

Expand All @@ -1576,7 +1580,11 @@ fma_get_mantissa(__m256 x)
__m256 denormal_mask = _mm256_cmp_ps(x, _mm256_set1_ps(FLT_MIN), _CMP_LT_OQ);
__m256 normal_mask = _mm256_cmp_ps(x, _mm256_set1_ps(FLT_MIN), _CMP_GE_OQ);

__m256 temp1 = _mm256_blendv_ps(x, _mm256_set1_ps(0.0f), normal_mask);
/*
* It is necessary for temp1 to be volatile, a bug in clang optimizes it out which leads
* to an overflow warning in some cases. See https://github.com/numpy/numpy/issues/18005
*/
volatile __m256 temp1 = _mm256_blendv_ps(x, _mm256_set1_ps(0.0f), normal_mask);
__m256 temp = _mm256_mul_ps(temp1, two_power_100);
x = _mm256_blendv_ps(x, temp, denormal_mask);

Expand Down
5 changes: 5 additions & 0 deletions numpy/core/tests/test_umath.py
Expand Up @@ -926,6 +926,11 @@ def test_log_values(self):
assert_raises(FloatingPointError, np.log, np.float32(-np.inf))
assert_raises(FloatingPointError, np.log, np.float32(-1.0))

# See https://github.com/numpy/numpy/issues/18005
with assert_no_warnings():
a = np.array(1e9, dtype='float32')
np.log(a)

def test_sincos_values(self):
with np.errstate(all='ignore'):
x = [np.nan, np.nan, np.nan, np.nan]
Expand Down

0 comments on commit dc3fe03

Please sign in to comment.