Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fixed file handle leak in array_tofile. #17775

Merged
merged 6 commits into from Nov 15, 2020
Merged

BUG: Fixed file handle leak in array_tofile. #17775

merged 6 commits into from Nov 15, 2020

Commits on Nov 14, 2020

  1. BUG: Fixed file handle leak in array_tofile. 

    The dup-ed file handle created in array_tofile is now closed when PyArray_ToFile fails.
    @simon-graham @charris
    simon-graham authored and charris committed Nov 14, 2020
    Copy the full SHA
    1ecb869 View commit details
    Browse the repository at this point in the history

  2. Update numpy/core/src/multiarray/methods.c 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @simon-graham @eric-wieser @charris
    2 people authored and charris committed Nov 14, 2020
    Copy the full SHA
    5e39405 View commit details
    Browse the repository at this point in the history

  3. BUG: array_tofile now always closes the original file handle.

    @simon-graham @charris
    simon-graham authored and charris committed Nov 14, 2020
    Copy the full SHA
    d71148a View commit details
    Browse the repository at this point in the history

  4. BUG: Made array_tofile exception safe.

    @simon-graham @charris
    simon-graham authored and charris committed Nov 14, 2020
    Copy the full SHA
    bb572db View commit details
    Browse the repository at this point in the history

  5. MAINT: Refactored array_tofile to use a helper function.

    @simon-graham @charris
    simon-graham authored and charris committed Nov 14, 2020
    Copy the full SHA
    cf122e8 View commit details
    Browse the repository at this point in the history

  6. TST: Check that tofile closes its Python handle when we pass it a str. 

    If we pass a str to tofile() rather than an open file object, it will open a Python handle. Make sure that it gets closed correctly.
    @simon-graham @charris
    simon-graham authored and charris committed Nov 14, 2020
    Copy the full SHA
    6a834f1 View commit details
    Browse the repository at this point in the history