BUG: Fixed file handle leak in array_tofile. #17775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dup-ed file handle created in array_tofile is now closed when PyArray_ToFile fails.
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
If we pass a str to tofile() rather than an open file object, it will open a Python handle. Make sure that it gets closed correctly.
charris
added
00 - Bug
component: numpy._core
08 - Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #17598.
Closes #17589
If the
PyArray_ToFilecall insidearray_tofilefails for any reason, we leak a dup-ed file handle. This causes problems especially on Windows OS, where any subsequent attempt to delete the file will fail because NumPy is still holding an open handle.This update ensures that we always close the handle.
The added test case forces
PyArray_ToFileto fail, which triggers the original problem.