Fix treatment of long file paths in Windows

examples/long-paths.js

@@ -0,0 +1,41 @@
+// This test creates a file with a path that's over 300 characters
+// long, which is longer than the Windows limit unless you use the
+// '\\?\' prefix.
+// https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247%28v=vs.85%29.aspx
+//
+// Then it passes that directory into and out of fstream, to see if
+// that file comes out the other side. This tests
+// https://github.com/npm/fstream/issues/30
+
+var tap = require('tap')
+var temp = require('temp').track()
+var fs = require('fs')
+var path = require('path')
+var mkdirp = require('mkdirp')
+var fstream = require('../fstream.js')
+
+tap.test('long file paths', function (t) {
+  var inputDir = temp.mkdirSync('fstream-test-input')
+  var outputDir = temp.mkdirSync('fstream-test-output')
+
+  var longDir = inputDir
+  while (longDir.length < 300) {
+    longDir = path.join(longDir, 'subdirectory')
+  }
+
+  var STAMP = 'stamp'
+
+  mkdirp.sync(longDir)
+  var inputStampedFile = path.join(longDir, 'file')
+  fs.writeFileSync(inputStampedFile, STAMP)
+
+  var onPipeComplete = function () {
+    var outputStampedFile = inputStampedFile.replace(inputDir, outputDir)
+    t.equal(fs.readFileSync(outputStampedFile, 'utf-8'), STAMP)
+    t.end()
+  }
+
+  var reader = fstream.Reader(inputDir)
+  reader.on('end', onPipeComplete)
+  reader.pipe(fstream.Writer(outputDir))
+})

examples/symlink-write.js

@@ -1,25 +1,28 @@
 var fstream = require('../fstream.js')
 var notOpen = false
 
-fstream
-  .Writer({
-    path: 'path/to/symlink',
-    linkpath: './file',
-    isSymbolicLink: true,
-    mode: '0755' // octal strings supported
-  })
-  .on('close', function () {
-    notOpen = true
-    var fs = require('fs')
-    var s = fs.lstatSync('path/to/symlink')
-    var isSym = s.isSymbolicLink()
-    console.log((isSym ? '' : 'not ') + 'ok 1 should be symlink')
-    var t = fs.readlinkSync('path/to/symlink')
-    var isTarget = t === './file'
-    console.log((isTarget ? '' : 'not ') + 'ok 2 should link to ./file')
-  })
-  .end()
+// No symlinks on Windows
+if (process.platform !== 'win32') {
+  fstream
+    .Writer({
+      path: 'path/to/symlink',
+      linkpath: './file',
+      isSymbolicLink: true,
+      mode: '0755' // octal strings supported
+    })
+    .on('close', function () {
+      notOpen = true
+      var fs = require('fs')
+      var s = fs.lstatSync('path/to/symlink')
+      var isSym = s.isSymbolicLink()
+      console.log((isSym ? '' : 'not ') + 'ok 1 should be symlink')
+      var t = fs.readlinkSync('path/to/symlink')
+      var isTarget = t === './file'
+      console.log((isTarget ? '' : 'not ') + 'ok 2 should link to ./file')
+    })
+    .end()
 
-process.on('exit', function () {
-  console.log((notOpen ? '' : 'not ') + 'ok 3 should be closed')
-})
+  process.on('exit', function () {
+    console.log((notOpen ? '' : 'not ') + 'ok 3 should be closed')
+  })
+}

lib/reader.js

@@ -97,15 +97,8 @@ function Reader (props, currentStat) {
 
   self._path = self.path = path.resolve(props.path)
   if (process.platform === 'win32') {
+    // XXX What is this code for?
     self.path = self._path = self.path.replace(/\?/g, '_')
-    if (self._path.length >= 260) {
-      // how DOES one create files on the moon?
-      // if the path has spaces in it, then UNC will fail.
-      self._swallowErrors = true
-      // if (self._path.indexOf(" ") === -1) {
-      self._path = '\\\\?\\' + self.path.replace(/\//g, '\\')
-      // }
-    }
   }
   self.basename = props.basename = path.basename(self.path)
   self.dirname = props.dirname = path.dirname(self.path)

lib/writer.js

@@ -72,11 +72,8 @@ function Writer (props, current) {
 
   self._path = self.path = path.resolve(props.path)
   if (process.platform === 'win32') {
+    // XXX What is this code for?
     self.path = self._path = self.path.replace(/\?/g, '_')
-    if (self._path.length >= 260) {
-      self._swallowErrors = true
-      self._path = '\\\\?\\' + self.path.replace(/\//g, '\\')
-    }
   }
   self.basename = path.basename(props.path)
   self.dirname = path.dirname(props.path)

package.json

@@ -19,7 +19,8 @@
   },
   "devDependencies": {
     "tap": "",
-    "standard": "^2.3.2"
+    "standard": "^2.3.2",
+    "temp": "^0.8.1"
   },
   "scripts": {
     "test": "standard && tap examples/*.js"