Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Fix treatment of long file paths in Windows #42

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix treatment of long file paths in Windows #42

wants to merge 3 commits into from

Commits on Mar 24, 2015

  1. Add test for long file paths 

    This test reads and write a directory with a path
that is above 300 characters long, and checks
that it comes out the other side.

Currently, this test fails on Windows due to
https://www.npmjs.com/package/standard. A
subsequent commit will fix this.
    @avital
    avital committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    c07de3d View commit details
    Browse the repository at this point in the history

  2. Disable symlink test on Windows

    @avital
    avital committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    a7b34f7 View commit details
    Browse the repository at this point in the history

  3. Fix treatment of long file paths in Windows 

    3e5d171 (from November 2011) introduced this code to fix treatment
of long file paths in Windows. Then, one week later, this commit
fixed long file paths directly in Node's `fs` library:
nodejs/node-v0.x-archive@1f16a7b

So, the code currently in fstream actually /breaks/ long file
paths in Windows.

This fixes it, but keeps an additional mysterious line introduced
by that original commit that I don't understand.

Fixes npm#30. Thanks to @sdarnell for identifying the problem.
    @avital
    avital committed Mar 24, 2015
    Configuration menu
    Copy the full SHA
    d11b9ec View commit details
    Browse the repository at this point in the history