Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add deprecation warnings to access commands #5347

Merged
merged 1 commit into from Aug 25, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar requested a review from a team as a code owner August 22, 2022 20:18
@wraithgar wraithgar changed the title fix: add deprecation warnings to access commands feat: add deprecation warnings to access commands Aug 22, 2022
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Aug 22, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 42.248 ±0.30 17.747 ±0.14 15.643 ±0.00 19.172 ±1.72 2.743 ±0.00 2.755 ±0.01 2.251 ±0.04 10.984 ±0.10 2.217 ±0.01 3.182 ±0.13
#5347 40.851 ±3.65 17.734 ±0.10 15.806 ±0.19 18.060 ±0.84 2.664 ±0.01 2.764 ±0.04 2.251 ±0.01 10.819 ±0.05 2.234 ±0.01 3.339 ±0.09
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 30.285 ±1.01 13.456 ±0.02 11.635 ±0.36 12.798 ±0.96 2.516 ±0.01 2.552 ±0.02 2.198 ±0.01 7.961 ±0.11 2.158 ±0.01 2.841 ±0.02
#5347 29.753 ±1.42 13.315 ±0.12 11.945 ±0.15 12.831 ±0.07 2.537 ±0.02 2.537 ±0.01 2.234 ±0.01 7.924 ±0.03 2.137 ±0.01 2.913 ±0.03

Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to block this for now until we've had a discussion about whether npm/statusboard#477 can land prior to v9. If not, then we should likely hold on removing these commands for another major cycle (which would be crappy) but the timeframe may be tight 🤷🏼‍♂️ let's chat today about it.

@wraithgar wraithgar marked this pull request as draft August 23, 2022 16:39
@wraithgar wraithgar marked this pull request as ready for review August 25, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants