Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate some access subcommands #5155

Closed
wants to merge 1 commit into from

Conversation

fritzy
Copy link
Contributor

@fritzy fritzy commented Jul 12, 2022

Added warning logs for npm access <subcommand> for the following subcommands:

  • 2fa-required
  • 2fa-not-required
  • public
  • restricted
  • edit
  • ls-packages
  • ls-collaborators

@fritzy fritzy requested a review from a team as a code owner July 12, 2022 17:02
@wraithgar
Copy link
Member

ref: npm/statusboard#486

@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 37.305 ±0.29 17.302 ±0.07 15.401 ±0.27 17.965 ±0.81 2.705 ±0.00 2.684 ±0.04 2.187 ±0.04 10.595 ±0.10 2.148 ±0.01 3.154 ±0.00
#5155 38.039 ±1.40 17.652 ±0.15 15.119 ±0.02 17.912 ±0.98 2.700 ±0.01 2.696 ±0.00 2.163 ±0.00 10.620 ±0.01 2.155 ±0.01 3.219 ±0.05
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 27.983 ±0.83 13.073 ±0.14 11.335 ±0.02 12.000 ±0.18 2.504 ±0.01 2.443 ±0.01 2.235 ±0.02 7.706 ±0.02 2.059 ±0.01 3.171 ±0.42
#5155 27.664 ±1.33 13.492 ±0.71 11.383 ±0.13 12.301 ±0.09 2.468 ±0.01 2.471 ±0.03 2.223 ±0.01 7.688 ±0.07 2.069 ±0.02 2.887 ±0.06

Copy link
Contributor

@darcyclarke darcyclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this until npm/statusboard#477 is out so as to not confuse folks about what they'd use going forward. Notably, set|get|list can/likely should be added in v8 prior to these deprecation warnings.

@darcyclarke darcyclarke added the semver:minor new backwards-compatible feature label Jul 26, 2022
@wraithgar
Copy link
Member

We got our wires crossed and duplicated this effort in #5347

@wraithgar wraithgar closed this Sep 8, 2022
@wraithgar wraithgar deleted the fritzy/access-deprecations branch September 8, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor new backwards-compatible feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants