Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove test coverage map #4862

Merged
merged 1 commit into from May 7, 2022
Merged

fix: remove test coverage map #4862

merged 1 commit into from May 7, 2022

Commits on May 5, 2022

  1. fix: remove test coverage map

    Turns out there were three files that still had no test coverage because
    of the combination of the mocks in tests and the coverage map.  Removing
    the map altogether exposed them.
    
    This PR removes the coverage map and fixes test to cover all lines that
    were being missed.
    
    While adding coverage to the `npm search` codebase multiple unneeded
    guards and at least one bug was found (it was impossible to exclude
    searches based on username). These were fixed.
    
    The `npm view` tests were also refactored to use the real npm object.
    
    Finally, a small inlining of lib/utils/file-exists.js was done.
    wraithgar committed May 5, 2022
    Copy the full SHA
    eae9637 View commit details
    Browse the repository at this point in the history