fix: remove test coverage map #4862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
force-pushed
the
gar/no-coverage-map
branch
from
2b9424a
to
9be58d5
Compare
|
no statistically significant performance changes detected timing results
|
wraithgar
force-pushed
the
gar/no-coverage-map
branch
3 times, most recently
from
3b70063
to
f11fd1b
Compare
ruyadorno
reviewed
May 5, 2022
| return [] | ||
| } | ||
|
|
||
| module.exports = coverageMap |
Turns out there were three files that still had no test coverage because of the combination of the mocks in tests and the coverage map. Removing the map altogether exposed them. This PR removes the coverage map and fixes test to cover all lines that were being missed. While adding coverage to the `npm search` codebase multiple unneeded guards and at least one bug was found (it was impossible to exclude searches based on username). These were fixed. The `npm view` tests were also refactored to use the real npm object. Finally, a small inlining of lib/utils/file-exists.js was done.
wraithgar
force-pushed
the
gar/no-coverage-map
branch
from
f11fd1b
to
eae9637
Compare
ruyadorno
approved these changes
May 5, 2022
maricarlagumbay1
added a commit
to maricarlagumbay1/cli
that referenced
this pull request
May 8, 2022
This reverts commit 48d2db6.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there were three files that still had no test coverage because
of the combination of the mocks in tests and the coverage map. Removing
the map altogether exposed them.
This PR removes the coverage map and fixes test to cover all lines that
were being missed.
While adding coverage to the
npm searchcodebase multiple unneededguards and at least one bug was found (it was impossible to exclude
searches based on username). These were fixed.
The
npm viewtests were also refactored to use the real npm object.