Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x-backport] Backport 24861 to v11.x #25258

Closed
wants to merge 2 commits into from
Closed

[v11.x-backport] Backport 24861 to v11.x #25258

wants to merge 2 commits into from

Commits on Dec 28, 2018

  1. test,doc: add tests and docs for addon unloading 

    Originally from portions of nodejs#23319.

PR-URL: nodejs#24861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    @addaleax
    addaleax authored and Gabriel Schulhof committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    1c2b202 View commit details
    Browse the repository at this point in the history

  2. src: unload addons when environment quits 

    This is an alternative to nodejs#23319
which attaches the loaded addons to the environment and closes them
when the environment is destroyed.

PR-URL: nodejs#24861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Gabriel Schulhof committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    fdf2e3c View commit details
    Browse the repository at this point in the history