Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v11.x-backport] Backport 24861 to v11.x #25258

Closed
wants to merge 2 commits into from
Closed

[v11.x-backport] Backport 24861 to v11.x #25258

wants to merge 2 commits into from

Conversation

gabrielschulhof
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Re: #24861 (comment)

addaleax and others added 2 commits December 28, 2018 11:30
@addaleax
test,doc: add tests and docs for addon unloading
1c2b202 
Originally from portions of nodejs#23319.

PR-URL: nodejs#24861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
src: unload addons when environment quits
fdf2e3c 
This is an alternative to nodejs#23319
which attaches the loaded addons to the environment and closes them
when the environment is destroyed.

PR-URL: nodejs#24861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2095/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. v11.x labels Dec 28, 2018
@targos
Copy link
Member

targos commented Dec 29, 2018

What was the conflict?

@gabrielschulhof
Copy link
Contributor Author

@targos I didn't run into a conflict. I made this PR because there was a backport-requested tag. I was surprised to find no conflict. I figured although there might not be a source code conflict the tests might fail or something, but they didn't fail locally.

@gabrielschulhof
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/19899/

targos pushed a commit that referenced this pull request Jan 1, 2019
@addaleax @targos
test,doc: add tests and docs for addon unloading
95353c7 
Originally from portions of #23319.

Backport-PR-URL: #25258
PR-URL: #24861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
@targos
src: unload addons when environment quits
d718625 
This is an alternative to #23319
which attaches the loaded addons to the environment and closes them
when the environment is destroyed.

Backport-PR-URL: #25258
PR-URL: #24861
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos
Copy link
Member

targos commented Jan 1, 2019

Landed in 95353c7 and d718625. Thanks!

@targos targos closed this Jan 1, 2019
@MylesBorins
Copy link
Member

This needed to be tested with CITGM before it was landed. The original commits were breaking node-report

@MylesBorins MylesBorins mentioned this pull request Jan 18, 2019
Merged
@addaleax
Copy link
Member

@MylesBorins I’m not sure, but maybe adding a backport request to a change that broke something in CITGM is a bit confusing? We still want a clean CITGM on master, so dont-land + a request to investigate could be a better approach for the future?

@targos targos added this to Closed PRs in v11.x Jan 30, 2019
@gabrielschulhof gabrielschulhof deleted the backport-24861-to-v11.x branch June 14, 2019 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
No open projects
v11.x
  
Closed PRs
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gabrielschulhof @nodejs-github-bot @targos @MylesBorins @addaleax