"callback already called" error #3008

PierreMarieRiviere · 2020-04-26T07:59:02Z

I've asked for help in the Truffle Gitter before filing this issue.

Issue

Deploying on testnet fails with Error: callback already called (but deployment on Ganache succeeds).
The mentioned callback is at /node_modules/truffle/build/webpack:/~/ganache-core/~/merkle-patricia-tree/~/async/lib/async.js:358.

Steps to Reproduce

npx truffle unbox okwme/truffle-shavings

Create the .env as required here https://github.com/okwme/truffle-shavings
Delete truffle-config,js

yarn migrate --network rinkeby

You should get the error

Expected Behavior

Contract should be deployed on Rinkby or any other testnet

Actual Results

$yarn migrate --network rinkeby
yarn run v1.22.4
$ npx truffle migrate --network rinkeby

Compiling your contracts...
===========================
> Compiling ./contracts/Migrations.sol
> Compiling ./contracts/Sample.sol
> Artifacts written to /Users/Pm/Documents/Ethereum/test2/build/contracts
> Compiled successfully using:
   - solc: 0.5.0+commit.1d4f565a.Emscripten.clang


/Users/Pm/Documents/Ethereum/test2/node_modules/truffle/build/webpack:/~/ganache-core/~/merkle-patricia-tree/~/async/lib/async.js:358
                callback(err);
^
Error: Callback was already called.
    at /Users/Pm/Documents/Ethereum/test2/node_modules/truffle/build/webpack:/~/ganache-core/~/merkle-patricia-tree/~/async/lib/async.js:43:1
    at WriteStream.<anonymous> (/Users/Pm/Documents/Ethereum/test2/node_modules/truffle/build/webpack:/~/ganache-core/~/merkle-patricia-tree/~/async/lib/async.js:358:1)
    at WriteStream.emit (events.js:315:20)
    at WriteStream.destroy (/Users/Pm/Documents/Ethereum/test2/node_modules/truffle/build/webpack:/~/level-ws/level-ws.js:140:1)
    at finish (_stream_writable.js:681:14)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Environment

OSX 10.15.3 (Catalina)
Web3.js v1.2.1
Truffle v5.1.23 (core: 5.1.23)
• Solidity v0.5.16 (solc-js)
Node v14.0.0
npm 6.14.4
• yarn 1.22.4

The text was updated successfully, but these errors were encountered:

PierreMarieRiviere · 2020-04-27T15:18:23Z

To anyone meeting this problem it could be due to
(1) Node 14. Revert to LTS (12.16.2 at time of writing)
(2) Anything else. Sorry. I formatted my computer in the meantime. Maybe some elder sudo messing up with my config.

eggplantzzz · 2020-04-27T16:01:44Z

@TheDApact thanks for reporting this and for the repro steps! I'll take a look into why this is happening.

eggplantzzz · 2020-04-27T16:22:16Z

I was unable to duplicate your error. I tried with both Node 10 and 12. I could successfully migrate to ropsten like you instructed. I wonder what could be going on here.

PierreMarieRiviere · 2020-04-27T16:25:22Z

I was on Node 14.0 best bet it's from Node.

Node 12.0 does it!

eggplantzzz · 2020-04-27T16:37:16Z

I was able to on Node 14 too. Try upgrading your version of Truffle in the package.json. Currently it is set at ^5.0.2. Set it to at least ^5.1.0. My guess is that you are experiencing a bug we have already fixed. I was using the latest version of Truffle installed globally on my machine. Let me know what happens.

PierreMarieRiviere · 2020-04-27T17:21:41Z

Still getting the same error with node 14.0 after upgrading truffle to ^5.1.0 in package.json.

At least we confirmed it stems from node 14.0

edit: same with 5.1.23

eggplantzzz · 2020-04-27T18:43:41Z

No I meant to say that I was able to successfully migrate to ropsten using Node 14. I'm not sure what's up with this. Are you using a globally installed version of Truffle? If so, can you do a truffle version just to ensure you are using the most recent version? I know we had some bug a while back that gave the error message that you reported...

PierreMarieRiviere · 2020-04-28T03:26:13Z

Here is my environment

Truffle v5.1.23 (core: 5.1.23)
Solidity v0.5.16 (solc-js)
Node v14.0.0
Web3.js v1.2.1

npx truffle migrate will work if I downgrade Node to 12.16.2

Here are the packages installed globally on my (just formatted) OSX Catalina

├── npm@6.14.4
├── truffle@5.1.23
└── yarn@1.22.4

Worse mentioning that I added the snippet below to package.json found in the box, to fix an error with fsevent (see nodejs/node#27389)

"resolutions": {
    "**/**/fsevents": "^1.2.9"
 },

eggplantzzz · 2020-04-28T15:09:05Z

Hmm weird, it looks like I can duplicate your error with Node 14 today. I think it is unrelated to the resolutions property you mentioned above as I could duplicate it without it. We'll have to look into this later, thanks for the report! I really would like to get rid of the async library from the Truffle codebase :)

nicholasjpaterno · 2020-05-01T12:16:08Z

I really would like to get rid of the async library from the Truffle codebase :)

Your wish is my command 🧞

eggplantzzz · 2020-05-11T14:27:53Z

So the async library was removed from the latest version of Truffle (5.1.25) and re-attempting this migration I get the same error. So it looks like this error does not come from Truffle's direct usage of the library but is rather something else. More investigation will be necessary.

glowkeeper · 2020-06-03T14:11:41Z

Same error with this:

Truffle v5.1.25 (core: 5.1.25)
Solidity - 0.6.6 (solc-js)
Node v14.2.0
Web3.js v1.2.1

But everything is just fine with this:

Truffle v5.1.8 (core: 5.1.8)
Solidity - 0.6.6 (solc-js)
Node v12.14.1
Web3.js v1.2.1

WillMandrill · 2020-06-07T17:45:23Z

Hello

I am having the same error. Is this a bug?

/versions/node/v14.3.0/lib/node_modules/truffle/build/webpack:/node_modules/merkle-patricia-tree/node_modules/async/lib/async.js:358
callback(err);
^
Error: Callback was already called.

Truffle v5.1.28 (core: 5.1.28)
Solidity - 0.6.8 (solc-js)
Node v14.3.0
Web3.js v1.2.1

Thank you

Will

JavierTrujilloG · 2020-06-24T13:58:02Z

I was experiencing the same problem with Node v14.4.0
After switching to Node v12.0.0 with nvm it worked like a charm.

CruzMolina · 2020-06-24T14:19:30Z

@PierreMarieRiviere This is an issue related to ganache-core's internals not yet being Node 14 compatible (trufflesuite/ganache#732).

You should be able to to deploy to any of the production networks (including testnets) with truffle on Node 14, by skipping the dry run (truffle migrate --network rinkeby --skipDryRun). The dry run uses ganache's forking feature to simulate the deployment for production networks.

DanielTongAwesome · 2020-06-27T00:40:19Z

I was experiencing the same problem with the following setting:
Truffle v5.1.31
node v14.4.0
Solidity v0.5.0

It works for me after I tried 'truffle migrate --network rinkeby --skipDryRun'

@PierreMarieRiviere This is an issue related to ganache-core's internals not yet being Node 14 compatible (trufflesuite/ganache-cli#732).

You should be able to to deploy to any of the production networks (including testnets) with truffle on Node 14, by skipping the dry run (truffle migrate --network rinkeby --skipDryRun). The dry run uses ganache's forking feature to simulate the deployment for production networks.

Thank you !

TanjaNY · 2020-08-26T09:09:37Z

same issue.
Truffle v5.1.41 (core: 5.1.41)
Solidity v0.5.16 (solc-js)
Node v14.5.0
Web3.js v1.2.1

glowkeeper · 2020-08-26T10:27:27Z

My experience is that it is broken with N0de v14 - revert to v12.

…

On Wed, 26 Aug 2020 at 10:09, Tanja Nyberg ***@***.***> wrote: same issue. Truffle v5.1.41 (core: 5.1.41) Solidity v0.5.16 (solc-js) Node v14.5.0 Web3.js v1.2.1 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3008 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACGV6IL5FLRK2FDFW6ZLZTDSCTGOBANCNFSM4MRDSLHQ> .

TanjaNY · 2020-08-26T10:36:04Z

'truffle migrate --network ropsten --skipDryRun' worked for me though.

glowkeeper · 2020-08-26T10:43:03Z

*--skipDryRun*

Nice!

…

On Wed, 26 Aug 2020 at 11:36, Tanja Nyberg ***@***.***> wrote: *'truffle migrate --network ropsten --skipDryRun'* worked for me though. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3008 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACGV6II6XGCQW7KWGSZU2ZTSCTQSHANCNFSM4MRDSLHQ> .

felipegontijo · 2020-09-17T13:28:38Z

Skipping Dry Run also worked for me.

Note: it can be added in the networks configs in truffle-config.js as skipDryRun: true as well!

Why isn't this issue closed already? Or are there implications on skipping the dry run, so waiting for a "permanent" fix?

eggplantzzz · 2020-09-18T15:27:00Z

Is there anything else actionable here on this issue (other than supporting Node 14)? Just to reiterate, Truffle is not currently compatible with Node 14. Part of the problem is that Ganache is not yet compatible with Node 14 and Truffle uses that "under the hood".

ashutoshsinghparmar · 2020-10-29T17:31:30Z

had same issue with migrate to any live network:
Environment:
Truffle v5.1.46 (core: 5.1.46)
Solidity v0.5.16 (solc-js)
Node v14.13.0
Web3.js v1.2.1

skipDryRun worked for me too....
@CruzMolina Thanks...

eggplantzzz · 2020-10-30T15:35:41Z

@ashu12318 Try upgrading to the latest Truffle. It is only as of Truffle version 5.1.49 that Truffle has been compatible with Node 14.

steelep · 2021-01-22T08:37:41Z

I was getting this with the latest version of truffle attempting to deploy to mainnet. Kovan & Ropsten deployments worked fine.

Work around was adding "skipDryRun: true" to truffle-config.js for mainnet.

SomeJoker · 2021-05-26T07:13:45Z

I try to use "skipDryRun" but not success。But I find use V12.22.1 node solve this problem( My original version is 14.17.0 )。
sudo npm install n -g
n 12.22.1
then I success to run
truffle migrate --network rinkeby

eggplantzzz · 2021-05-26T15:20:24Z

Is there anything else actionable on this? Otherwise we will go ahead and close this issue. Thanks!

SomeJoker · 2021-05-27T03:08:04Z

now, I meet another problem。 when I run truffle compile, I got a
'Eorror: Could not find a compiler version matching 0.6.10. Please ensure you are specifying a valid version, constraint or build in the truffle config. Run truffle compile --list to see available versions'
I run 'truffle compile --list --all' ,can got version list, include I want version(0.6.10).
so, how to slove this problem.

haltman-at · 2022-02-09T19:07:30Z

@SomeJoker That sounds like an unrelated issue, so if you're still having a problem with that, you should open a new issue for it. Meanwhile, we're going to close this one. Thanks!

williamCareyJr · 2022-04-01T20:19:40Z

When I use truffle migrate --network kovan --skipDryRun
I receive the following error:

**Error: *** Deployment Failed ***

"Migrations" -- Web3ProviderEngine does not support synchronous requests..**

haltman-at · 2022-04-04T18:58:00Z

@williamCareyJr That sounds like a different issue. Would you mind filing a new issue for that, with more detailed reproduction steps? Thanks!

YashNagiReddy7 · 2022-05-04T07:20:54Z

even I have faced the same error, I have used nvm use 16 and did truffle migrate --reset --skipdryrun, it worked for mr and the contract has been deployed!

AGRTECH · 2022-12-04T20:17:33Z

Thanks so much for this guys I was getting this same error and I was on node 16 and reverted back to 12 and I was able to deploy onto goerli

haltman-at added the priority2 ⚠️ label May 6, 2020

d0gf4rt mentioned this issue Apr 11, 2021

Error: Callback was already called. ProjectOpenSea/opensea-erc1155#37

Closed

julien51 mentioned this issue Jun 12, 2021

Hardhat unlock-protocol/unlock#7207

Closed

6 tasks

haltman-at closed this as completed Feb 9, 2022

voidcenter mentioned this issue Jan 5, 2024

yarn test meet error Uniswap/v2-core#194

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"callback already called" error #3008

"callback already called" error #3008

PierreMarieRiviere commented Apr 26, 2020 •

edited

PierreMarieRiviere commented Apr 27, 2020

eggplantzzz commented Apr 27, 2020

eggplantzzz commented Apr 27, 2020 •

edited

PierreMarieRiviere commented Apr 27, 2020 •

edited

eggplantzzz commented Apr 27, 2020

PierreMarieRiviere commented Apr 27, 2020 •

edited

eggplantzzz commented Apr 27, 2020 •

edited

PierreMarieRiviere commented Apr 28, 2020

eggplantzzz commented Apr 28, 2020 •

edited

nicholasjpaterno commented May 1, 2020

eggplantzzz commented May 11, 2020

glowkeeper commented Jun 3, 2020 •

edited

WillMandrill commented Jun 7, 2020

JavierTrujilloG commented Jun 24, 2020

CruzMolina commented Jun 24, 2020 •

edited

DanielTongAwesome commented Jun 27, 2020 •

edited

TanjaNY commented Aug 26, 2020

glowkeeper commented Aug 26, 2020 via email

TanjaNY commented Aug 26, 2020

glowkeeper commented Aug 26, 2020 via email

felipegontijo commented Sep 17, 2020

eggplantzzz commented Sep 18, 2020

ashutoshsinghparmar commented Oct 29, 2020

eggplantzzz commented Oct 30, 2020

steelep commented Jan 22, 2021

SomeJoker commented May 26, 2021 •

edited

eggplantzzz commented May 26, 2021

SomeJoker commented May 27, 2021

haltman-at commented Feb 9, 2022

williamCareyJr commented Apr 1, 2022

haltman-at commented Apr 4, 2022

YashNagiReddy7 commented May 4, 2022

AGRTECH commented Dec 4, 2022

"callback already called" error #3008

"callback already called" error #3008

Comments

PierreMarieRiviere commented Apr 26, 2020 • edited

Issue

Steps to Reproduce

Expected Behavior

Actual Results

Environment

PierreMarieRiviere commented Apr 27, 2020

eggplantzzz commented Apr 27, 2020

eggplantzzz commented Apr 27, 2020 • edited

PierreMarieRiviere commented Apr 27, 2020 • edited

eggplantzzz commented Apr 27, 2020

PierreMarieRiviere commented Apr 27, 2020 • edited

eggplantzzz commented Apr 27, 2020 • edited

PierreMarieRiviere commented Apr 28, 2020

eggplantzzz commented Apr 28, 2020 • edited

nicholasjpaterno commented May 1, 2020

eggplantzzz commented May 11, 2020

glowkeeper commented Jun 3, 2020 • edited

WillMandrill commented Jun 7, 2020

JavierTrujilloG commented Jun 24, 2020

CruzMolina commented Jun 24, 2020 • edited

DanielTongAwesome commented Jun 27, 2020 • edited

TanjaNY commented Aug 26, 2020

glowkeeper commented Aug 26, 2020 via email

TanjaNY commented Aug 26, 2020

glowkeeper commented Aug 26, 2020 via email

felipegontijo commented Sep 17, 2020

eggplantzzz commented Sep 18, 2020

ashutoshsinghparmar commented Oct 29, 2020

eggplantzzz commented Oct 30, 2020

steelep commented Jan 22, 2021

SomeJoker commented May 26, 2021 • edited

eggplantzzz commented May 26, 2021

SomeJoker commented May 27, 2021

haltman-at commented Feb 9, 2022

williamCareyJr commented Apr 1, 2022

haltman-at commented Apr 4, 2022

YashNagiReddy7 commented May 4, 2022

AGRTECH commented Dec 4, 2022

PierreMarieRiviere commented Apr 26, 2020 •

edited

eggplantzzz commented Apr 27, 2020 •

edited

PierreMarieRiviere commented Apr 27, 2020 •

edited

PierreMarieRiviere commented Apr 27, 2020 •

edited

eggplantzzz commented Apr 27, 2020 •

edited

eggplantzzz commented Apr 28, 2020 •

edited

glowkeeper commented Jun 3, 2020 •

edited

CruzMolina commented Jun 24, 2020 •

edited

DanielTongAwesome commented Jun 27, 2020 •

edited

SomeJoker commented May 26, 2021 •

edited