Skip to content
This repository has been archived by the owner on May 18, 2022. It is now read-only.

Attempt to upgrade to node v12 #238

Merged
merged 2 commits into from
Jun 10, 2020
Merged

Attempt to upgrade to node v12 #238

merged 2 commits into from
Jun 10, 2020

Conversation

joeyAghion
Copy link
Contributor

  • Added an engines entry in package.json
  • Removed conflicting npm install yarn ... from Dockerfile
  • Had trouble installing a compatible fsevents version (fsevents @1.2.7 | @1.2.8 does not build with Node 12 nodejs/node#27389), but upgrading to >=1.2.9 helped. (Specifying a fsevents version in resolutions helped, but caused the optional dep to attempt installation in the linux container where it was incompatible.)
  • Added --frozen-lockfile to surface any inconsistencies between what's declared and what's going on within the container

I saw 3 consistent failures when running tests locally, but hokusai test would sometimes succeed. I'm not familiar enough with Kaws's builds to know if this is a new problem or it's always unstable.

@eessex
Copy link
Contributor

eessex commented Jun 10, 2020

Type check is failing due to the yarn orb version - bump to v5 should fix it.

@eessex
Copy link
Contributor

eessex commented Jun 10, 2020

This looks good from here, going to merge and monitor.

@eessex eessex merged commit f31692d into artsy:master Jun 10, 2020
@artsy-peril artsy-peril bot mentioned this pull request Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants