Ecosystem Modules that will break in Node 12 #25060

targos · 2018-12-15T12:52:03Z

This is an issue meant to track modules that are currently skipped in citgm because they (or their tests) are currently broken on current versions of Node.

Module name	Node version	Reason	Refs
uglify-js	master	Output expectation in tests	mishoo/UglifyJS#3304
time	11, master	Crash when called with NaN	TooTallNate/node-time#76
stylus	11, master	Fixed version unreleased	stylus/stylus#2436
graceful-fs	11, master	Tests broken	isaacs/node-graceful-fs#137
bcrypt	master	Using removed V8 API	kelektiv/node.bcrypt.js#684
microtime	master	Using removed V8 API	wadey/node-microtime#61
serialport	master	Using removed V8 API	serialport/node-serialport#1742
ref	master	Using removed V8 API	TooTallNate/ref#107
node-report	master	Using removed V8 API	nodejs/node-report#116
sqlite3	master	Using removed V8 API	TryGhost/node-sqlite3#1093
leveldown	master	Using removed V8 API	Level/leveldown#540
level	master	Using removed V8 API	Level/level#123
iconv	master	Using removed V8 API	bnoordhuis/node-iconv#198
node-gyp	master	Using removed V8 API	nodejs/node-gyp#1705

Feel free to edit this post to update the table.

richardlau · 2018-12-15T13:24:19Z

Duplicate of #25059. I like the table layout here but also prefer the title of #25059. We should probably pin whichever one we go with.

targos · 2018-12-15T13:30:02Z

@mcollina Sorry I missed your issue. I also prefer to have a table layout. I added a column with checkboxes.

mcollina · 2018-12-15T13:35:56Z

I’m ok of closing my issue but changing the title of this one.

targos · 2018-12-15T14:27:12Z

I added sqlite3, leveldown, level and iconv to the list. Someone should open an issue for the first 3.

mcollina · 2018-12-15T14:55:12Z

leveldown is fixed in the upcoming v5 release cc @ralphtheninja.

silverwind · 2018-12-15T18:52:59Z

Filed mishoo/UglifyJS#3304 for uglify-js.

Not a big issue overall, they are basically testing the console output format, no real breakage, so I agree to ignoring it in citgm.

reconbot · 2018-12-16T03:31:02Z

serialport should be fixed in master, lmk

jdalton · 2018-12-16T05:32:23Z

@silverwind Might want to see if this affects terser.

silverwind · 2018-12-16T09:19:27Z

@jdalton terser/terser#197.

Flarna · 2018-12-17T06:57:46Z

Quite some of the fails are because of NAN which is not yet prepared for Node 12 but V8 API has changed since Node 10/11.
To my understanding a V8 update to 7.2 is pending (#24875) which may include further breaking changes. Is it needed to create a Nan version for such an in between version of node?

targos · 2018-12-17T07:34:28Z

According to the Chromium release calendar, I think we will aim for V8 7.4 in Node 12, maybe with a forward-compat patch to have the API of V8 7.5.
Knowing that, it might indeed be too early to adapt NAN. The problem is that in the mean time, we have no way to know if changes in core are going to break native modules that depend on NAN.

mcollina · 2018-12-17T07:43:46Z

As far as I know, V8 does not plan to remove any of the non-deprecated methods in non-major releases. Is this assumption correct? cc @nodejs/v8.

I think the plan should be to just remove all usage of currently deprecated methods in V8 in master.

targos · 2018-12-17T07:45:49Z

@mcollina that's correct, but what they often do is deprecate in a version (e.g. 7.3) and remove in the next (7.4).

Flarna · 2018-12-17T07:46:06Z

Knowing that, it might indeed be too early to adapt NAN. The problem is that in the mean time, we have no way to know if changes in core are going to break native modules that depend on NAN.

I created nodejs/nan#831 I think this is a better place to discuss this in detail.

hashseed · 2018-12-17T07:49:47Z

V8 removes APIs by first marking them V8_DEPRECATED, and waits at least one version bump (e.g. 7.3 to 7.4) before actually removing it.

That said, we take precautions for the time around Node.js LTS releases to not unnecessarily break ABI stability.

hashseed · 2018-12-17T08:01:43Z

I created a roadmap for V8 in Node.js 12 here.

richardlau · 2019-03-29T19:25:50Z

I updated iconv and node-report as they both fail again due to the V8 update to 7.4.

The new errors for those modules are coming from nan.

PR fix for node-report: nodejs/node-report#125

devsnek · 2019-03-29T19:41:15Z

Math.pow now works identical to the exponential operator.

we might also want to call this out in the change log

richardlau · 2019-03-31T19:01:41Z

Fixed node-report in 2.2.5.

richardlau · 2019-04-01T23:57:58Z

Added node-gyp: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1781/nodes=debian9-64/testReport/junit/(root)/citgm/node_gyp_v3_8_0/

PR fix: nodejs/node-gyp#1705

kibertoad · 2019-04-02T23:00:11Z

Sqlite and node-gyp fixes also merged, no?

refack · 2019-04-02T23:25:24Z

Sqlite and node-gyp fixes also merged, no?

Merged but not shipped yet.

joshunger · 2019-04-25T23:35:16Z

Should this be added here? facebook/create-react-app#6891

tripower · 2019-05-08T11:25:27Z

node-java v0.11.0 seems also not to be working with node v12.0.0
https://github.com/joeferner/node-java

rvagg · 2019-05-08T12:48:20Z

bignum isn't working with 12 and it's causing some angst. justmoon/node-bignum#120

It could really do with a conversion to node-addon-api but the distance between nan and addon-api for object wrapped addons with lots of constructor work is a bit too much of a stretch for me with the limited mental bandwidth I can afford for it.

I have publish rights if someone wants to do the work though!

sam-github · 2019-05-08T16:26:28Z

I fixed the test failure with the bignum PR porting o 12.x, but don't have time ATM for a rewrite.

splitice · 2019-06-05T06:36:40Z

weak-napi (alternative to weak) is also broken. I have attempted to fix it but it's segfaulting sometimes for a reason that's beyond me.

targos · 2019-06-05T06:47:33Z

The weak-napi test suite passes for me (Node.js 12.4.0):

$ citgm weak-napi
info:    starting            | weak-napi           
info:    lookup              | weak-napi           
info:    lookup-notfound     | weak-napi           
info:    lookup-githead      | https://github.com/node-ffi-napi/weak-napi/archive/3efed548b5cd5ec2f3f82858eeae8d9bbd5d26e6.tar.gz
info:    weak-napi npm:      | Downloading project: https://github.com/node-ffi-napi/weak-napi/archive/3efed548b5cd5ec2f3f82858eeae8d9bbd5d26e6.tar.gz
info:    weak-napi npm:      | Project downloaded weak-napi-1.0.3.tgz
info:    weak-napi npm:      | npm install started 
warn:    weak-napi npm-install:| In file included from ../src/weakref.cc:2:                                                                                                                                                                                                         
warn:                          | /tmp/9300544d-093c-4fad-bf41-11189928c9ac/weak-napi/node_modules/setimmediate-napi/include/setimmediate.h: In instantiation of ‘void SetImmediate(napi_env, T&&) [with T = {anonymous}::ObjectInfo::OnFree()::<lambda()>; napi_env = napi_env__*]’:
warn:                          | ../src/weakref.cc:25:6:   required from here                                                                                                                                                                                                       
warn:                          | /tmp/9300544d-093c-4fad-bf41-11189928c9ac/weak-napi/node_modules/setimmediate-napi/include/setimmediate.h:46:7: warning: catching polymorphic type ‘class Napi::Error’ by value [-Wcatch-value=]                                                   
warn:                          | 46 |     } catch (Napi::Error e) {                                                                                                                                                                                                                 
warn:                          | |       ^~~~~                                                                                                                                                                                                                                      
info:    weak-napi npm:      | npm install successfully completed
info:    weak-napi npm:      | test suite started  
info:    passing module(s)   |                     
info:    module name:        | weak-napi           
info:    version:            | 1.0.3               
info:    done                | The smoke test has passed.
info:    duration            | test duration: 13746ms

Do you have a reproducible test case that segfaults?

splitice · 2019-06-05T06:55:11Z

@targos Heres the corresponding issue node-ffi-napi/weak-napi#16

I've got to the point that the test cases pass (using nodejs/node-addon-api#475), but real world stressing code triggers segfaults. I'm on 12.3.x I'll upgrade my test to 12.4.0 and re-confirm with vanilla napi and patched.

splitice · 2019-06-05T08:01:41Z

I can confirm the issue exists with 12.4.0 both with vanilla napi and patched.

nickdesaulniers · 2019-06-30T23:24:31Z

node-nanomsg broken in v12: nickdesaulniers/node-nanomsg#206

ybiquitous · 2019-07-01T12:51:50Z

Hi, graceful-fs seems to support Node 12 now. See Travis build below:

https://travis-ci.org/isaacs/node-graceful-fs/jobs/550978466

johnnysprinkles · 2019-07-12T07:12:53Z

Not sure if https://github.com/TooTallNate is active on the ref package -- and that's blocking all use of FFI on Node 12...

silverwind · 2019-07-12T08:11:34Z

Do we need to keep this open? Node 12 is released and I understand this issue was to track issues before release. Posting Node 12 issues here will not magically fix them.

ybiquitous · 2019-07-12T08:46:04Z

The head version of stylus seems to accept Node 12. See the CI log below:
https://travis-ci.org/stylus/stylus/jobs/552691143#L439

But not released yet…

targos · 2019-07-12T09:10:20Z

@silverwind You're right, let's close this.

targos added help wanted Issues that need assistance from volunteers or PRs that need help to proceed. meta Issues and PRs related to the general management of the project. labels Dec 15, 2018

targos added this to the 12.0.0 milestone Dec 15, 2018

targos mentioned this issue Dec 15, 2018

lookup: skip graceful-fs on >=11 nodejs/citgm#655

Merged

richardlau changed the title ~~citgm: tracking skipped modules~~ Ecosystem Modules that will break in Node 12 Dec 15, 2018

richardlau pinned this issue Dec 15, 2018

richardlau mentioned this issue Dec 15, 2018

Ecosystem Modules that will break in Node 12 #25059

Closed

9 tasks

targos mentioned this issue Dec 15, 2018

Check if citgm is clean on Node master nodejs/citgm#660

Closed

This was referenced Dec 15, 2018

Release new major v5.0.0 Level/leveldown#550

Closed

Release new major v5.0.0 Level/level#123

Closed

refack mentioned this issue Dec 15, 2018

make compatible with V8 7.1 TryGhost/node-sqlite3#1093

Merged

silverwind mentioned this issue Dec 16, 2018

Make tests compatible with Node.js 12 and prerelease versions terser/terser#197

Merged

richardlau mentioned this issue Dec 17, 2018

citgm: the canary for graceful-fs is not feeling so good #24381

Closed

Flarna mentioned this issue Dec 17, 2018

add support for node master nodejs/nan#831

Merged

piranna mentioned this issue Apr 24, 2019

core dump when installing with Node.js 12 #27385

Closed

Trott removed this from the 12.0.0 milestone Apr 28, 2019

julien-noblet mentioned this issue Apr 30, 2019

Node 12 not compiling leveldown julien-noblet/cad-killer#505

Closed

SimenB mentioned this issue Apr 30, 2019

Doesn't work with weak on Node 12 jestjs/jest#8397

Closed

jdalton unpinned this issue May 1, 2019

ybiquitous mentioned this issue May 12, 2019

Add Node.js 12 to CIs stylelint/stylelint#4072

Merged

jbuget mentioned this issue May 15, 2019

[TECH] Montée de version de NPM. 1024pix/pix#505

Closed

millette mentioned this issue Jun 16, 2019

Node v12 support strapi/strapi#3342

Closed

targos closed this as completed Jul 12, 2019

markokajzer mentioned this issue Dec 9, 2019

Installation failed Rantanen/node-opus#93

Closed

Ecosystem Modules that will break in Node 12 #25060

Ecosystem Modules that will break in Node 12 #25060

Comments

targos commented Dec 15, 2018 • edited

richardlau commented Dec 15, 2018

targos commented Dec 15, 2018

mcollina commented Dec 15, 2018

targos commented Dec 15, 2018

mcollina commented Dec 15, 2018

silverwind commented Dec 15, 2018 • edited

reconbot commented Dec 16, 2018 • edited

jdalton commented Dec 16, 2018

silverwind commented Dec 16, 2018

Flarna commented Dec 17, 2018

targos commented Dec 17, 2018

mcollina commented Dec 17, 2018

targos commented Dec 17, 2018

Flarna commented Dec 17, 2018

hashseed commented Dec 17, 2018

hashseed commented Dec 17, 2018

richardlau commented Mar 29, 2019

devsnek commented Mar 29, 2019

richardlau commented Mar 31, 2019

richardlau commented Apr 1, 2019

kibertoad commented Apr 2, 2019

refack commented Apr 2, 2019

joshunger commented Apr 25, 2019

tripower commented May 8, 2019

rvagg commented May 8, 2019

sam-github commented May 8, 2019

splitice commented Jun 5, 2019

targos commented Jun 5, 2019

splitice commented Jun 5, 2019

splitice commented Jun 5, 2019

nickdesaulniers commented Jun 30, 2019

ybiquitous commented Jul 1, 2019

johnnysprinkles commented Jul 12, 2019

silverwind commented Jul 12, 2019 • edited

ybiquitous commented Jul 12, 2019 • edited

targos commented Jul 12, 2019

targos commented Dec 15, 2018 •

edited

silverwind commented Dec 15, 2018 •

edited

reconbot commented Dec 16, 2018 •

edited

silverwind commented Jul 12, 2019 •

edited

ybiquitous commented Jul 12, 2019 •

edited