[TECH] Montée de version de NPM. #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Node 10.15.3 (LTS) we are currently in NPM v6.4.1. Few days ago, NPM released the 6.9.0 (cf. https://npm.community/t/release-npm-6-9-0/5911). Upgrading the NPM version will add a step in the environment installation. But not doing so, display a waring during each `npm install` command execution. In the next steps, we will try to upgrade Node version (with the risk of leaving a comfortable LTS version). If the upgrade does not work, we will have to take a decision about the version we keep of Node / NPM. Maybe the PR associated to this commit will never finished in production. 🤷♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Edit - 15/05/2019 13h40]
La montée de version s’est mal passée. De nombreux modules importants ne sont pas compatibles Node 12 ~ nodejs/node#25060
Autant
bcryptsemble passé côté API (malgré la présence dans le tableau) ~ kelektiv/node.bcrypt.js#684 , autantuglify-jscasse le build ~ mishoo/UglifyJS#3304.Il faudrait effectuer la montée version des apps Ember en 3.10 (depuis hier), pour voir si ça passe.
Mais là ça nous emmène beaucoup plus loin que mon intention première. J’annule. On va continuer à se taper le message de warning un certain temps. Désolé.
🦄 Problème
NPM a effectué une mise à jour dont les changements sont décrits ici.
🤖 Solution
Mise à jour de tous les fichiers package.json, package-lock.json et du README.md.
🌈 Remarques
Au passage, cette PR corrige dans CircleCI une vieille configuration de Node (10.15.1 au lieu de 10.15.3).