Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

citgm: the canary for graceful-fs is not feeling so good #24381

Closed
refack opened this issue Nov 15, 2018 · 1 comment
Closed

citgm: the canary for graceful-fs is not feeling so good #24381

refack opened this issue Nov 15, 2018 · 1 comment
Labels
fs Issues and PRs related to the fs subsystem / file system. memory Issues and PRs related to the memory management or memory footprint. needs-citgm PRs that need a CITGM CI run. v8 engine Issues and PRs related to the V8 dependency.

Comments

@refack
Copy link
Contributor

refack commented Nov 15, 2018

  • Version: mater
  • Platform: multiple
  • Subsystem: fs

ATM this is masked by nodejs/citgm#618

TAP version 13
# Subtest: node.exe --expose-gc test/avoid-memory-leak.js
# Subtest: no memory leak when loading multiple times
1..1
not ok 1 - We expect less than 2MB difference, but 26MB is still claimed.
---
at:
line: 20
column: 15
file: test/avoid-memory-leak.js
type: global
function: importFreshGracefulFs
stack: |
importFreshGracefulFs (test/avoid-memory-leak.js:20:15)
process.nextTick (test/avoid-memory-leak.js:14:36)
source: >
t.ok(memoryUsageMB < 2, 'We expect less than 2MB difference, but ' +
memoryUsageMB + 'MB is still claimed.');
...
# failed 1 test
not ok 1 - no memory leak when loading multiple times # time=3941.176ms
1..1
# failed 1 test
# time=3981.323ms
not ok 1 - node.exe --expose-gc test/avoid-memory-leak.js # time=4848.078ms
---
command: 'd:\bin\dev\node\node.exe'
args:
- '--expose-gc'
- test/avoid-memory-leak.js
stdio:
- 0
- pipe
- 2
cwd: 'd:\temp\usr\732639ec-10cc-4342-b51e-d8a6657eaf56\graceful-fs'
exitCode: 1
...
@refack refack added fs Issues and PRs related to the fs subsystem / file system. v8 engine Issues and PRs related to the V8 dependency. memory Issues and PRs related to the memory management or memory footprint. needs-citgm PRs that need a CITGM CI run. labels Nov 15, 2018
@richardlau
Copy link
Member

Tracking this as part of #25060.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. memory Issues and PRs related to the memory management or memory footprint. needs-citgm PRs that need a CITGM CI run. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

2 participants