Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-gyp 5.0 breaks support for Electron versions < 4 #1778

Closed
MarshallOfSound opened this issue Jun 14, 2019 · 0 comments
Closed

node-gyp 5.0 breaks support for Electron versions < 4 #1778

MarshallOfSound opened this issue Jun 14, 2019 · 0 comments

Comments

@MarshallOfSound
Copy link
Member

MarshallOfSound commented Jun 14, 2019

  • Node Version: Unrelated
  • Platform: All
  • Compiler: Unrelated
  • Module: Any

This PR --> #1670 removes support for obsolete io.js versions, this is perfectly valid however because of the way that logic was originally implemented, over on the Electron team for our 1.x/2.x/3.x releases, we had to publish our headers with the iojs prefix instead of the node prefix.

As of node-gyp@5.0 these versions no longer work and currently we still support Electron 3 so ideally this would be fixed. I've raised a simple "revent the PR that broke it" PR, if that's acceptable it would be great to merge and release that, otherwise I can craft a PR to specifically introduce support back for these headers.

Revert PR: #1777
Refs: electron/electron#18787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants