Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade dependencies #305

Merged
merged 5 commits into from Aug 16, 2019
Merged

chore: upgrade dependencies #305

merged 5 commits into from Aug 16, 2019

Conversation

malept
Copy link
Member

@malept malept commented Jun 13, 2019

The main changes are upgrading TypeScript (which required some source changes) and upgrading node-gyp.

Closes #311.
Closes #315.

@malept
Copy link
Member Author

malept commented Jun 14, 2019

For transparency, it was discovered that node-gyp@5.0.0 does not work with Electron 3: nodejs/node-gyp#1778

@malept
Copy link
Member Author

malept commented Aug 16, 2019

The CircleCI error is a red herring (until #306 is merged), so I'm just going to merge this. Unfortunately, I don't have publish rights (a bus factor problem which will also be resolved in #306), so I'll ask @MarshallOfSound in the morning.

@malept malept merged commit b695c0d into master Aug 16, 2019
@malept malept deleted the upgrade-dependencies-3 branch August 16, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

electron-rebuild is broken with the newest MSBuild because it uses an old node-gyp
1 participant