Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete another directory in Windows build script #918

Merged
merged 8 commits into from Jun 19, 2019
Merged

Delete another directory in Windows build script #918

merged 8 commits into from Jun 19, 2019

Conversation

murgatroid99
Copy link
Member

This directory is taken from the NodeJS build error logs in #917.

@murgatroid99
Copy link
Member Author

The Linux Electron Build and Windows Tests failures appear to be related to network failures when running node-gyp. Rerunning to see if that's just temporary.

@murgatroid99
Copy link
Member Author

I switched to node-gyp 4 because I saw the following problems that appeared specific to node-gyp 5: nodejs/node-gyp#1778, and some odd linkage failures on Windows that I have been unable to replicate outside of the CI environment. However, node-gyp 4 appears to have a different problem: many of these builds are failing with strange network failures that I have also been unable to replicate outside of the CI environment.

@murgatroid99 murgatroid99 merged commit c08cb62 into grpc:master Jun 19, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolasnoble nicolasnoble nicolasnoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@murgatroid99 @nicolasnoble @kokoro-team