Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicitly import http and https modules due to bundler limitations #2586

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: explicitly import http and https modules due to bundler limitations #2586

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d17cdab
fix: for some reason you need to require both http and https
perrin4869 Feb 8, 2024
36ecd1d
Update lib/common.js
gr2m Feb 8, 2024
040a259
Merge branch 'main' into fix/require-both-http-and-https
Uzlopak Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/common.js
View file
Open in desktop
Expand Up @@ -70,7 +70,13 @@ function overrideRequests(newRequest) {
debug('- overriding request for', proto)

const moduleName = proto // 1 to 1 match of protocol and module is fortunate :)
const module = require(proto)
// TODO: figure out why you need to require both modules instead of doing the following:
// const module = require(proto)
// https://github.com/nock/nock/pull/2572
gr2m marked this conversation as resolved.
Show resolved Hide resolved
const module = {
http: require('http'),
https: require('https'),
}[moduleName]
const overriddenRequest = module.request
const overriddenGet = module.get

Expand Down