fix: explicitly import http and https modules due to bundler limitations

[perrin4869]

My CI broke because of a change in #2572
Some other people later mentioned this issue, but no one has yet found the root cause
Honestly I am curious but don't have the time to dig into it at this moment...

[Uzlopak]

Ok, weird. Maybe some security issue?

[perrin4869]

Ohhh ok I finally got it 😅
It's because of the bundler 😅

Could not dynamically require \"http\". Please configure the dynamicRequireTargets or/and ignoreDynamicRequires option of @rollup/plugin-commonjs appropriately for this require call to work.

I'll try to come up with a workaround, but yeah, it's not necessarily a bug with nock after-all. I guess it was coded in this way originally in order to play ball with rollup, maybe the author was using a setup similar to mine?

[gr2m]

It's usually a problem with bundling. I'd reopen and merge this PR but add a comment that we need to explicitly import both modules due to some bundlers not being able to handle dynamic imports

[perrin4869]

hm... yeah, avoiding the dynamic imports would make life easier for the bundlers, but this should also be fixed in rollup side ^^;;
I'm leaning towards sending a PR to allow for dynamic require of built-in node modules, that should fix the issue here at least

[gr2m]

Not all bundlers use rollup, we can't rely on it. This might become a non-issue anyway in future versions as we change the way requests are intercepted, I'd just revert to the previous behavior which was importing both modules statically

[gr2m]

Not sure why CI is failing though 😓