fix: Throw errors when base URLs are specified incorrectly [WIP]

README.md

@@ -54,7 +54,6 @@ For instance, if a module performs HTTP requests to a CouchDB server or makes HT
   - [Request Body filtering](#request-body-filtering)
   - [Request Headers Matching](#request-headers-matching)
   - [Optional Requests](#optional-requests)
-  - [Axios](#axios)
   - [Allow **unmocked** requests on a mocked hostname](#allow-unmocked-requests-on-a-mocked-hostname)
 - [Expectations](#expectations)
   - [.isDone()](#isdone)
@@ -88,6 +87,7 @@ For instance, if a module performs HTTP requests to a CouchDB server or makes HT
       - [Example](#example)
     - [Modes](#modes)
 - [Common issues](#common-issues)
+  - [Axios](#axios)
 - [Debugging](#debugging)
 - [Contributing](#contributing)
 - [Contributors](#contributors)

lib/interceptor.js

@@ -376,7 +376,7 @@ module.exports = class Interceptor {
   }
 
   matchHostName(options) {
-    return options.hostname === this.scope.urlParts.hostname
+    return options.hostname === this.scope.parsedUrl.hostname
   }
 
   matchQuery(options) {

lib/scope.js

@@ -13,6 +13,7 @@ const { EventEmitter } = require('events')
 const globalEmitter = require('./global_emitter')
 const util = require('util')
 const Interceptor = require('./interceptor')
+const { URL } = url
 
 let fs
 
@@ -48,21 +49,27 @@ class Scope extends EventEmitter {
     this.matchHeaders = []
     this.logger = debug
     this.scopeOptions = options || {}
-    this.urlParts = {}
     this._persist = false
     this.contentLen = false
     this.date = null
-    this.basePath = basePath
-    this.basePathname = ''
-    this.port = null
     this._defaultReplyHeaders = []
 
-    if (!(basePath instanceof RegExp)) {
-      this.urlParts = url.parse(basePath)
-      this.port =
-        this.urlParts.port || (this.urlParts.protocol === 'http:' ? 80 : 443)
-      this.basePathname = this.urlParts.pathname.replace(/\/$/, '')
-      this.basePath = `${this.urlParts.protocol}//${this.urlParts.hostname}:${this.port}`
+    if (basePath instanceof RegExp) {
+      this.basePath = basePath
+      this.basePathname = ''
+      this.port = null
+      this.parsedUrl = {}
+    } else {
+      this.parsedUrl = new URL(basePath)
+      const { protocol, hostname, port, pathname } = this.parsedUrl
+      if (protocol !== 'http:' && protocol !== 'https:') {
+        throw new TypeError(
+          `Protocol '${protocol}' not recognized. This commonly occurs when a hostname and port are included without a protocol, producing a URL that is valid but confusing, and probably not what you want.`
+        )
+      }
+      this.port = port || (protocol === 'http:' ? 80 : 443)
+      this.basePathname = pathname.replace(/\/$/, '')
+      this.basePath = `${protocol}//${hostname}:${this.port}`
     }
   }
 
@@ -76,7 +83,7 @@ class Scope extends EventEmitter {
       interceptor,
       this,
       this.scopeOptions,
-      this.urlParts.hostname
+      this.parsedUrl.hostname
     )
   }
 

tests/test_intercept.js

@@ -1452,3 +1452,25 @@ test('works when headers are removed on the socket event', t => {
       t.end()
     })
 })
+
+// https://github.com/nock/nock/issues/1061
+test('invalid URLs throw', t => {
+  ;['localhost:1234', 'localhost:1234/url'].forEach(invalidUrl => {
+    t.throws(() => nock('localhost:1234/url'), {
+      message: `Protocol 'localhost:' not recognized. This commonly occurs when a hostname and port are included without a protocol, producing a URL that is valid but confusing, and probably not what you want.`,
+    })
+  })
+  ;[
+    'localhost',
+    '127.0.0.1',
+    '127.0.0.1:1234',
+    '127.0.0.1:1234/url',
+    'foo.com/api',
+  ].forEach(invalidUrl => {
+    t.throws(() => nock(invalidUrl), {
+      input: invalidUrl,
+      name: 'TypeError [ERR_INVALID_URL]',
+    })
+  })
+  t.end()
+})