fix: Throw errors when base URLs are specified incorrectly [WIP]

[paulmelnikow]

• Switch to the new URL API which throws errors for most invalid inputs
• Throw errors for URLs with unrecognized schemes
• Add tests for cases that previously had been handled incorrectly

Closes #1061
Supersedes #1065

This is arguably a breaking change as it throws errors in cases where the previous code would no-op. How we consider it is related to the discussion in #1673.

[paulmelnikow]

Interesting failure. While url.parse('http://[2607:f0d0:1002:51::4]:8080').hostname drops the brackets and produces '2607:f0d0:1002:51::4', new URL('http://[2607:f0d0:1002:51::4]:8080').hostname keeps the brackets and produces '[2607:f0d0:1002:51::4]'.

It looks like Nock is concatenating the port onto the unbracketed IPv6 addresses, which seems less ideal:

connect EHOSTUNREACH 2607:f0d0:1002:51::4:8080 - Local (:::64394)

I don't think this has a functional effect, though aesthetically it seems like we should put the brackets in there. It improves readability of the error messages.

That requires a change in the way matching happens – we need to re-bracket options.host.

A separate adjustment probably is needed to preserve backward compatibility of IPv6 recordings in the current format.

[mastermatt]

👍

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We try to do our best, but nock is maintained by volunteers and there is only so much we can do at a time. Thank you for your contributions.

[gr2m]

@paulmelnikow would you like to finish up your work here? We can open it up to other contributors otherwise