Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest supported #1361

Merged
merged 10 commits into from
Jul 20, 2023
Merged

Update dependencies to latest supported #1361

merged 10 commits into from
Jul 20, 2023

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Jul 18, 2023

Pull Request

🤨 Rationale

Updates dependencies to the latest resolved by our package.json files without modifying those specifiers. Hoping it pre-emptively helps the discussion of issues around dependency changes but useful regardless.

As a bonus, fixes #1146

👩‍💻 Implementation

  • Regenerate the lock file (delete lock file, node_modules, and npm install)
  • Update CI node and npm version to reflect Skyline recent update and better reflect local dev
  • Pin Blazor playwright version to correspond to latest released on nuget.org (as of writing 1.36.0) vs latest released on npm which the previous specifier would resolve to (as of writing 1.36.1).
  • Update tests and stories based on lint rule behavior changes

🧪 Testing

Manual test storybook build but rely on CI for most.

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@rajsite rajsite enabled auto-merge (squash) July 19, 2023 23:44
@rajsite
Copy link
Member Author

rajsite commented Jul 19, 2023

@msmithNI @atmgrifter00 waiting on blazor reviewer

@rajsite
Copy link
Member Author

rajsite commented Jul 20, 2023

@msmithNI @atmgrifter00 waiting on blazor reviewer

Gonna override y'all. Can address concerns in a follow-up

@rajsite rajsite disabled auto-merge July 20, 2023 02:53
@rajsite rajsite merged commit 0541d6d into main Jul 20, 2023
7 checks passed
@rajsite rajsite deleted the update-deps-07-2023 branch July 20, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update storybook when SB7 regressions are fixed
3 participants