-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular integration for label providers #1360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦kens before attached to DOM)
msmithNI
commented
Jul 18, 2023
msmithNI
commented
Jul 18, 2023
...ngular/label-providers/core/tests/nimble-label-provider-core-with-defaults.directive.spec.ts
Outdated
Show resolved
Hide resolved
msmithNI
requested review from
rajsite,
atmgrifter00 and
jattasNI
as code owners
July 18, 2023 22:02
jattasNI
reviewed
Jul 19, 2023
change/@ni-nimble-components-6eb6eef1-eec2-4f6d-a98f-f7182ecdad50.json
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me but my vote is to wait for the deps update to go in and then clean up the package changes in this PR. So I'll wait to approve until after taking another look at the package files when that's done.
rajsite
reviewed
Jul 20, 2023
angular-workspace/projects/example-client-app/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
atmgrifter00
approved these changes
Jul 21, 2023
rajsite
approved these changes
Jul 21, 2023
jattasNI
approved these changes
Jul 21, 2023
1 task
rajsite
pushed a commit
that referenced
this pull request
Sep 6, 2023
β¦ich-text-editor (#1477) # Pull Request ## π€¨ Rationale Issue Link : #1288 Angular Integration for the rich text component label providers to get localized from the client app when using the rich text component ( For now only `rich-text-editor` has labels ). ## π©βπ» Implementation Reference PR for implementation: #1360 This PR adds `NimbleLabelProviderRichTextDirective` in nimble-angular. ## π§ͺ Testing - Added autotests for new directives ## β Checklist <!--- Review the list and put an x in the boxes that apply or ~~strike through~~ around items that don't (along with an explanation). --> - [x] I have updated the project documentation to reflect my changes or determined no changes are needed. --------- Co-authored-by: Aagash Raaj <aagash.maridas@solitontech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π€¨ Rationale
Partially addresses #1090 (Blazor changes will be a subsequent PR)
π©βπ» Implementation
See the HLD for the implementation plan for the label providers.
This PR adds in nimble-angular:
NimbleLabelProviderCoreDirective
andNimbleLabelProviderTableDirective
(standard wrappers)NimbleLabelProviderCoreWithDefaultsDirective
andNimbleLabelProviderCoreWithDefaultsDirective
: Apps will use these directives to automatically initialize the label providers with the localized strings (which use$localize
from@angular/localize
, which is now an optional peer dependency for nimble-angular)@ni/nimble-angular/label-provider/core
and@ni/nimble-angular/label-provider/table
NimbleLabelProviderCoreModule
and/orNimbleLabelProviderTableModule
to get the strings pulled in, which seemed like better behavior.π§ͺ Testing
<nimble-label-provider-core withDefaults></nimble-label-provider-core>
. Note that there's not additional translation logic in the example app though, so this just uses the English strings (so basically a no-op, just there as an example).β Checklist