Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(simple-editor): show additional actions inline #5906

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Apr 8, 2024

Before After
image image

@szaimen szaimen added 2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 23.31%. Comparing base (d7fbc3c) to head (357300d).
Report is 3 commits behind head on main.

Files Patch % Lines
src/views/EditSimple.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5906   +/-   ##
=========================================
  Coverage     23.31%   23.31%           
  Complexity      442      442           
=========================================
  Files           247      247           
  Lines         11444    11444           
  Branches       1923     1923           
=========================================
  Hits           2668     2668           
  Misses         8776     8776           
Flag Coverage Δ
javascript 14.59% <0.00%> (ø)
php 59.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szaimen szaimen force-pushed the enh/noid/show-inline branch 2 times, most recently from daf2b37 to fc5e549 Compare April 8, 2024 12:40
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen changed the title show additional actions inline feat(simple-editor): show additional actions inline Apr 8, 2024
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 8, 2024
@szaimen szaimen marked this pull request as ready for review April 8, 2024 12:52
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some actions are more important or relevant than others here. Showing all of them inline is a bit much and results in a lot of icons without text, which we want to avoid because it is not readily understandable for people who do not use the software every day. :)

  • Download and Copy is not as important as "Delete" and "Edit"
  • The actions belong more to "Edit" than they do to the close button at the top

That’s why I propose an adjustment like this:
calendar event

@szaimen
Copy link
Contributor Author

szaimen commented Apr 8, 2024

That’s why I propose an adjustment like this:
calendar event

Good idea to move them to the bottom! :)

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants