Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): show actions inline #5907

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Apr 8, 2024

Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen szaimen added 2. developing Work in progress design Related to design, interface, interaction design, UX, etc. enhancement New feature request labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.31%. Comparing base (d7fbc3c) to head (fd51382).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5907   +/-   ##
=========================================
  Coverage     23.31%   23.31%           
  Complexity      442      442           
=========================================
  Files           247      247           
  Lines         11444    11444           
  Branches       1923     1923           
=========================================
  Hits           2668     2668           
  Misses         8776     8776           
Flag Coverage Δ
javascript 14.59% <ø> (ø)
php 59.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #5906 (review)
→ I don’t think we should inline all these actions here, but rather move the menu (with Download and Copy) and the out-of-menu "Delete" next to the "Edit" button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to design, interface, interaction design, UX, etc. enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants