Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use infra-checkers static analysis settings #89

Merged
merged 2 commits into from Aug 24, 2022
Merged

chore: use infra-checkers static analysis settings #89

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de20bfb
chore: use infra-checkers static analysis settings
sigilioso Jul 28, 2022
f3ab1b5
chore: use env variable instead of hardcoded value
sigilioso Aug 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/push_pr.yml
View file
Open in desktop
Expand Up @@ -20,15 +20,19 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: '1.18'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a variable above GO_VERSION: '1.18'. Moreover, why now do we need to setup go here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed here f3ab1b5.

Go setup is needed to use golangci-lint-action v3. Review this for details.

- uses: newrelic/newrelic-infra-checkers@v1
with:
semgrep-append: false
golangci-lint-config: golangci-lint-limited
- name: Semgrep
uses: returntocorp/semgrep-action@v1
with:
auditOn: push
- name: golangci-lint
uses: golangci/golangci-lint-action@v3.1.0
uses: golangci/golangci-lint-action@v3
continue-on-error: ${{ github.event_name != 'pull_request' }}
with:
only-new-issues: true
Expand Down
102 changes: 0 additions & 102 deletions .golangci.yml
View file
Open in desktop

This file was deleted.