Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use infra-checkers static analysis settings #89

Merged
merged 2 commits into from Aug 24, 2022

Conversation

sigilioso
Copy link
Contributor

No description provided.

@sigilioso sigilioso requested a review from a team July 28, 2022 10:26
@sigilioso sigilioso marked this pull request as ready for review July 28, 2022 10:27
@kang-makes kang-makes marked this pull request as draft August 1, 2022 13:16
@sigilioso sigilioso marked this pull request as ready for review August 22, 2022 14:31
@@ -20,15 +20,19 @@ jobs:
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v2
- uses: actions/setup-go@v2
with:
go-version: '1.18'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a variable above GO_VERSION: '1.18'. Moreover, why now do we need to setup go here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed here f3ab1b5.

Go setup is needed to use golangci-lint-action v3. Review this for details.

@sigilioso sigilioso requested review from paologallinaharbur and a team August 23, 2022 13:16
@sigilioso sigilioso merged commit d4b04a5 into master Aug 24, 2022
@sigilioso sigilioso deleted the chore/static-analysis-settings branch August 24, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants