Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant epollWaitNow() call in EpollEventLoop#closeAll() #9614

Merged
merged 1 commit into from Oct 7, 2019
Merged

Remove redundant epollWaitNow() call in EpollEventLoop#closeAll() #9614

merged 1 commit into from Oct 7, 2019

Commits on Sep 27, 2019

  1. Remove redundant epollWaitNow() call in EpollEventLoop#closeAll() 

    Motivation

This is a vestige that was removed in the original PR netty#9535 before it
was reverted, but we missed it when re-applying in netty#9586.

It means there is a possible race condition because a wakeup event could
be missed while shutting down, but the consequences aren't serious since
there's a 1 second safeguard timeout when waiting for it.

Modification

Remove call to epollWaitNow() in EpollEventLoop#closeAll()

Result

Cleanup redundant code, avoid shutdown delay race condition
    @njhill
    njhill committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    003a81e View commit details
    Browse the repository at this point in the history