Remove redundant epollWaitNow() call in EpollEventLoop#closeAll() #9614
+0
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation This is a vestige that was removed in the original PR netty#9535 before it was reverted, but we missed it when re-applying in netty#9586. It means there is a possible race condition because a wakeup event could be missed while shutting down, but the consequences aren't serious since there's a 1 second safeguard timeout when waiting for it. Modification Remove call to epollWaitNow() in EpollEventLoop#closeAll() Result Cleanup redundant code, avoid shutdown delay race condition
|
Can one of the admins verify this patch? |
njhill
added a commit
to njhill/netty
that referenced
this pull request
Sep 27, 2019
Equivalent to 4.1 fix in netty#9614
|
@netty-bot test this please |
normanmaurer
approved these changes
Oct 7, 2019
|
@njhill thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a vestige that was removed in the original PR #9535 before it was reverted, but we missed it when re-applying in #9586.
It means there is a possible race condition because a wakeup event could be missed while shutting down, but the consequences aren't serious since there's a 1 second safeguard timeout when waiting for it.
Modification
Remove call to
epollWaitNow()inEpollEventLoop#closeAll()Result
Cleanup redundant code, avoid shutdown delay race condition