Add frameType method to Http2Frame.

[He-Pin]

Motivation:

Add frameType to Http2Frame, so I can use it more easily with switch expression than the current instance of.

Modification:

Add frameType to Http2Frame.

Result:

Easier to work with in Java < 17

[He-Pin]

Cause:

Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.15.4:cmp (default) on project netty-codec-http2: There is at least one incompatibility: io.netty.handler.codec.http2.AbstractHttp2StreamFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2DataFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2Frame.frameType():METHOD_ADDED_TO_INTERFACE,io.netty.handler.codec.http2.Http2GoAwayFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2HeadersFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2PingFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2PriorityFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2PushPromiseFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2ResetFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2SettingsAckFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2SettingsFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2StreamFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2UnknownFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2WindowUpdateFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE -> [Help 1]

            <excludes>
              <exclude>@io.netty.util.internal.UnstableApi</exclude>
              <exclude>io.netty.util.internal.shaded</exclude>
            </excludes>

it is marked with annotation, but still does not pass the japicmp check. strange.

[He-Pin]

Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.20.0:cmp (default) on project netty-buffer: There is at least one incompatibility: io.netty.buffer.Unpooled.copiedBuffer(byte[]):METHOD_NO_LONGER_VARARGS,io.netty.buffer.Unpooled.wrappedBuffer(byte[]):METHOD_NO_LONGER_VARARGS -> [Help 1]

reported : https://github.com/siom79/japicmp/issues

So another new issue found after upgrade the japicmp seems like an issue in japicmp

[normanmaurer]

I don't think k this is an acceptable breakage for 4.1

[He-Pin]

Still has :

Error:  Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.15.7:cmp (default) on project netty-codec-http2: There is at least one incompatibility: io.netty.handler.codec.http2.Http2Frame.frameType():METHOD_ADDED_TO_INTERFACE

:(

[He-Pin]

@normanmaurer thanks, I made this change because I saw it's marked with @UnstableApi
I'm planning migrate our internal jetty based spdy services to Netty's http/2 or http/3 one

[normanmaurer]

While it's marked as unstable I still feel not comfortable doing the changes as the benefit is not high enough vs maybe breaking people

[He-Pin]

I have to agree with you on this.

btw: I checked the Http2FrameCodec, and the Http3RequestStreamInboundHandler:
In Http2FrameCodec Netty following the on*Read style ,eg onDataRead/onGoAway read, but in the Http3RequestStreamInboundHandler IIRC, Netty is following channelRead() with overloaded methods style, is there any particular reason for the new design?

[He-Pin]

If there is a Netty 4.2.x release, then this should not be a problem with Java 8:)

[He-Pin]

I think with Java 8's default method, this will not cause any problem.