Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatibility reported even excludes with annotations. #394

Closed
He-Pin opened this issue Apr 21, 2024 · 3 comments
Closed

incompatibility reported even excludes with annotations. #394

He-Pin opened this issue Apr 21, 2024 · 3 comments

Comments

@He-Pin
Copy link

He-Pin commented Apr 21, 2024

Error: Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.15.7:cmp (default) on project netty-codec-http2: There is at least one incompatibility: io.netty.handler.codec.http2.AbstractHttp2StreamFrame:METHOD_ABSTRACT_ADDED_IN_IMPLEMENTED_INTERFACE,io.netty.handler.codec.http2.Http2Frame.frameType():METHOD_ADDED_TO_INTERFACE -> [Help 1]
Error:

Version 0.15.7, same in 0.20.0

The method was marked with

           <excludes>
              <exclude>@io.netty.util.internal.UnstableApi</exclude>
              <exclude>io.netty.util.internal.shaded</exclude>
            </excludes>

but still be reported during the maven verify

import io.netty.util.internal.UnstableApi;

/** An HTTP/2 frame. */
@UnstableApi
public interface Http2Frame {

    /**
     * Returns the type of the HTTP/2 frame e.g. DATA, GOAWAY, etc.
     */
    byte frameType();

    /**
     * Returns the name of the HTTP/2 frame e.g. DATA, GOAWAY, etc.
     */
    String name();
}

related issue: netty/netty#13989

@siom79
Copy link
Owner

siom79 commented Apr 21, 2024

Hello,
thanks for reporting.

Have you tried the option breakBuildIfCausedByExclusion? The exclude option otherwise only affects the reporting, not the breaking of the build.

siom79 added a commit that referenced this issue Apr 22, 2024
…ttributes() as this may throw a RuntimeException when CtClass is frozen
@siom79
Copy link
Owner

siom79 commented Apr 22, 2024

During investigation I realized that there was an issue with annotation loading of classes. Hence, I fixed this in this context.

@siom79 siom79 closed this as completed Apr 22, 2024
@siom79
Copy link
Owner

siom79 commented Apr 22, 2024

Released with 0.21.0.

normanmaurer added a commit to netty/netty that referenced this issue Apr 23, 2024
Motivation:

Bump japicmp to 0.21.0

Modification:

There was an issue in the newer version, but after reported now it's
fixed.
siom79/japicmp#393
siom79/japicmp#394

Result:

Bump japicmp to 0.21.0

---------

Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer added a commit to netty/netty that referenced this issue Apr 23, 2024
Motivation:

Bump japicmp to 0.21.0

Modification:

There was an issue in the newer version, but after reported now it's
fixed.
siom79/japicmp#393
siom79/japicmp#394

Result:

Bump japicmp to 0.21.0

---------

Co-authored-by: Norman Maurer <norman_maurer@apple.com>
He-Pin added a commit to He-Pin/netty that referenced this issue Apr 23, 2024
Motivation:

Bump japicmp to 0.21.0

Modification:

There was an issue in the newer version, but after reported now it's
fixed.
siom79/japicmp#393
siom79/japicmp#394

Result:

Bump japicmp to 0.21.0

---------

Co-authored-by: Norman Maurer <norman_maurer@apple.com>
normanmaurer added a commit to netty/netty that referenced this issue Apr 23, 2024
Motivation:

Bump japicmp to 0.21.0

Modification:

There was an issue in the newer version, but after reported now it's
fixed.
siom79/japicmp#393
siom79/japicmp#394

Result:

Bump japicmp to 0.21.0


Co-authored-by: Norman Maurer <norman_maurer@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants