Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit workaround on JDK-6427854 to Java <1.7 #11863

Merged

Commits on Nov 25, 2021

  1. Limit workaround on JDK-6427854 to Java <1.7

    Motivation:
    
    The workaround introduced by netty#203 (completed by netty#5644) on bug
    [JDK-6427854](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6427854)
    turns out to be no longer applicable since Java 1.7.
    
    Only first few builds of JDK 7 were affected by the bug, which got
    fixed in **build 8**. Since JDK 7 was feature complete in
    [build 123](https://blogs.oracle.com/java/post/jdk-7-feature-complete),
    there's no need to therefore apply the workaround since Java 1.7.
    
    Modifications:
    
    This commit makes sure the workaround (consisting in setting the system
    property `sun.nio.ch.bugLevel` to an empty string unless defined)
    doesn't get applied when the detected Java version is greater than or
    equal to 1.7.
    
    Result:
    
    The workaround gets only applied for Java versions strictly prior to 1.7.
    
    Conditioning the workaround to the Java version will incidentally help
    get rid of it when bumping up the minimum JDK support as proposed in
    various issues s.a. netty#8259 and netty#8540.
    rdesgroppes committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    4e95d10 View commit details
    Browse the repository at this point in the history