Limit workaround on JDK-6427854 to Java <1.7 #11863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The workaround introduced by netty#203 (completed by netty#5644) on bug [JDK-6427854](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6427854) turns out to be no longer applicable since Java 1.7. Only first few builds of JDK 7 were affected by the bug, which got fixed in **build 8**. Since JDK 7 was feature complete in [build 123](https://blogs.oracle.com/java/post/jdk-7-feature-complete), there's no need to therefore apply the workaround since Java 1.7. Modifications: This commit makes sure the workaround (consisting in setting the system property `sun.nio.ch.bugLevel` to an empty string unless defined) doesn't get applied when the detected Java version is greater than or equal to 1.7. Result: The workaround gets only applied for Java versions strictly prior to 1.7. Conditioning the workaround to the Java version will incidentally help get rid of it when bumping up the minimum JDK support as proposed in various issues s.a. netty#8259 and netty#8540.
rdesgroppes
force-pushed
the
limit-workaround-to-affected-java-versions
branch
from
30e6029
to
4e95d10
Compare
|
Thanks, @rdesgroppes. Have you signed the CLA? https://netty.io/wiki/developer-guide.html |
|
@chrisvest I hadn't, but it's now done. Thanks! |
|
(closed by mistake, sorry for the noise) |
chrisvest
approved these changes
Nov 25, 2021
|
@rdesgroppes thanks a lot! |
|
@normanmaurer you're welcome! Archaeology, kind of ;) |
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: The workaround introduced by netty#203 (completed by netty#5644) on bug [JDK-6427854](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6427854) turns out to be no longer applicable since Java 1.7. Only first few builds of JDK 7 were affected by the bug, which got fixed in **build 8**. Since JDK 7 was feature complete in [build 123](https://blogs.oracle.com/java/post/jdk-7-feature-complete), there's no need to therefore apply the workaround since Java 1.7. Modifications: This commit makes sure the workaround (consisting in setting the system property `sun.nio.ch.bugLevel` to an empty string unless defined) doesn't get applied when the detected Java version is greater than or equal to 1.7. Result: The workaround gets only applied for Java versions strictly prior to 1.7. Conditioning the workaround to the Java version will incidentally help get rid of it when bumping up the minimum JDK support as proposed in various issues s.a. netty#8259 and netty#8540.
laosijikaichele
pushed a commit
to laosijikaichele/netty
that referenced
this pull request
Dec 16, 2021
Motivation: The workaround introduced by netty#203 (completed by netty#5644) on bug [JDK-6427854](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6427854) turns out to be no longer applicable since Java 1.7. Only first few builds of JDK 7 were affected by the bug, which got fixed in **build 8**. Since JDK 7 was feature complete in [build 123](https://blogs.oracle.com/java/post/jdk-7-feature-complete), there's no need to therefore apply the workaround since Java 1.7. Modifications: This commit makes sure the workaround (consisting in setting the system property `sun.nio.ch.bugLevel` to an empty string unless defined) doesn't get applied when the detected Java version is greater than or equal to 1.7. Result: The workaround gets only applied for Java versions strictly prior to 1.7. Conditioning the workaround to the Java version will incidentally help get rid of it when bumping up the minimum JDK support as proposed in various issues s.a. netty#8259 and netty#8540.
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: The workaround introduced by netty#203 (completed by netty#5644) on bug [JDK-6427854](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6427854) turns out to be no longer applicable since Java 1.7. Only first few builds of JDK 7 were affected by the bug, which got fixed in **build 8**. Since JDK 7 was feature complete in [build 123](https://blogs.oracle.com/java/post/jdk-7-feature-complete), there's no need to therefore apply the workaround since Java 1.7. Modifications: This commit makes sure the workaround (consisting in setting the system property `sun.nio.ch.bugLevel` to an empty string unless defined) doesn't get applied when the detected Java version is greater than or equal to 1.7. Result: The workaround gets only applied for Java versions strictly prior to 1.7. Conditioning the workaround to the Java version will incidentally help get rid of it when bumping up the minimum JDK support as proposed in various issues s.a. netty#8259 and netty#8540.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The workaround introduced by #203 (completed by #5644) on bug JDK-6427854 turns out to be no longer applicable since Java 1.7.
Only first few builds of JDK 7 were affected by the bug, which got fixed in build 8. Since JDK 7 was feature complete in
build 123, there's no need to therefore apply the workaround from Java 1.7 onward.
Modifications:
This commit makes sure the workaround (consisting in setting the system property
sun.nio.ch.bugLevelto an empty string unless defined) doesn't get applied when the detected Java version is greater than or equal to 1.7.Result:
The workaround gets only applied for Java versions strictly prior to 1.7.
Conditioning the workaround to the Java version will incidentally help get rid of it when bumping up the minimum JDK support as proposed in various issues s.a. #8259 and #8540.