Ensure we only register native methods once #10876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
commented
Dec 17, 2020
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
Removed all this stuff as we can easily share it.
normanmaurer
force-pushed
the
native_fix
branch
from
7d41696
to
5372413
Compare
chrisvest
approved these changes
Dec 17, 2020
Motivation: We need to ensure we only register native methods once as otherwise we may end up in an "invalid" state. The problem here was that before it was basically the responsibility the user of transport-native-unix-common to register the methods. This is error prone as there may be multiple users of these on the classpath at the same time. Modifications: - Provide a way to init native lib without register the native methods of the provided classes. This is needed to be able to re-use functionality which is exposed to our internal native code - Use flatten plugin to correctly resolve classifier and so have the correct dependency - Call Unix.* method to ensure we register the methods correctly once - Include native lib as well in the native jars of unix-common Result: Be able to have multiple artifacts of the classpath that depends on the unix-common. Related to netty/netty-incubator-transport-io_uring#15
normanmaurer
force-pushed
the
native_fix
branch
from
d653d29
to
974ff29
Compare
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2021
Motivation: This reverts commit 7fb62a9 as it broke native loading in some cases due maven dependencies. Modification: Revert the commit. Result: Native loading works again
normanmaurer
added a commit
that referenced
this pull request
Jan 13, 2021
ZzxyNn
pushed a commit
to ZzxyNn/netty
that referenced
this pull request
Jan 29, 2021
…etty#10928) Motivation: This reverts commit 7fb62a9 as it broke native loading in some cases due maven dependencies. Modification: Revert the commit. Result: Native loading works again
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: We need to ensure we only register native methods once as otherwise we may end up in an "invalid" state. The problem here was that before it was basically the responsibility the user of transport-native-unix-common to register the methods. This is error prone as there may be multiple users of these on the classpath at the same time. Modifications: - Provide a way to init native lib without register the native methods of the provided classes. This is needed to be able to re-use functionality which is exposed to our internal native code - Use flatten plugin to correctly resolve classifier and so have the correct dependency - Call Unix.* method to ensure we register the methods correctly once - Include native lib as well in the native jars of unix-common Result: Be able to have multiple artifacts of the classpath that depends on the unix-common. Related to netty/netty-incubator-transport-io_uring#15
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
…etty#10928) Motivation: This reverts commit 7fb62a9 as it broke native loading in some cases due maven dependencies. Modification: Revert the commit. Result: Native loading works again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to ensure we only register native methods once as otherwise we may end up in an "invalid" state. The problem here was that before it was basically the responsibility the user of transport-native-unix-common to register the methods. This is error prone as there may be multiple users of these on the classpath at the same time.
Modifications:
Result:
Be able to have multiple artifacts of the classpath that depends on the unix-common. Related to netty/netty-incubator-transport-io_uring#15