Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we only register native methods once #10876

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Ensure we only register native methods once #10876

merged 1 commit into from
Dec 18, 2020

Commits on Dec 18, 2020

  1. Ensure we only register native methods once

    Motivation:
    
    We need to ensure we only register native methods once as otherwise we may end up in an "invalid" state. The problem here was that before it was basically the responsibility the user of transport-native-unix-common to register the methods. This is error prone as there may be multiple users of these on the classpath at the same time.
    
    Modifications:
    
    - Provide a way to init native lib without register the native methods of the provided classes. This is needed to be able to re-use functionality which is exposed to our internal native code
    - Use flatten plugin to correctly resolve classifier and so have the correct dependency
    - Call Unix.* method to ensure we register the methods correctly once
    - Include native lib as well in the native jars of unix-common
    
    Result:
    
    Be able to have multiple artifacts of the classpath that depends on the unix-common. Related to netty/netty-incubator-transport-io_uring#15
    normanmaurer committed Dec 18, 2020
    Configuration menu
    Copy the full SHA
    974ff29 View commit details
    Browse the repository at this point in the history