Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we don't register native methods for classes that are included… #31

Merged
merged 4 commits into from
Dec 18, 2020
Merged

Ensure we don't register native methods for classes that are included… #31

merged 4 commits into from
Dec 18, 2020

Conversation

normanmaurer
Copy link
Member

… in transport-native-unix-common

Motivation:

We need to ensure we not register methods for classes that are included in transport-native-unix-common as otherwise we may end up with a corrupt state which will cause problems

Modifications:

  • Update to latest netty snapshot that allows to not register methods
  • Correctly register methods by calling Unix static method
  • Ensure we have the correct dependency classifier by using the flatten plugin

Result:

Fixes #15

@normanmaurer
Ensure we don't register native methods for classes that are included…
bc5ffe8 
… in transport-native-unix-common

Motivation:

We need to ensure we not register methods for  classes that are included in transport-native-unix-common as otherwise we may end up with a corrupt state which will cause problems

Modifications:

- Update to latest netty snapshot that allows to not register methods
- Correctly register methods by calling Unix static method
- Ensure we have the correct dependency classifier by using the flatten plugin

Result:

Fixes #15
@normanmaurer
Copy link
Member Author

Depends on netty/netty#10876

@normanmaurer normanmaurer added this to the 0.0.3.Final milestone Dec 18, 2020
@normanmaurer normanmaurer merged commit 43ae34f into main Dec 18, 2020
@normanmaurer normanmaurer deleted the native_fix branch December 18, 2020 12:39
@1Jo1 1Jo1 mentioned this pull request Dec 23, 2020
Closed
@normanmaurer normanmaurer mentioned this pull request Jan 4, 2021
Closed
normanmaurer added a commit that referenced this pull request Jan 14, 2021
@normanmaurer
Upgrade to netty 4.1.58.Final and evert "Ensure we don't register nat…
ce68a83 
…ive methods for classes that are included… (#31)"

Motivation:

Upgrade netty and revert changes which are not compatible with latest
netty version

Modification:

This reverts commit 43ae34f and
upgrades to netty 4.1.58.Final.

Result:

Use latest netty release
@normanmaurer normanmaurer mentioned this pull request Jan 14, 2021
Merged
normanmaurer added a commit that referenced this pull request Jan 14, 2021
@normanmaurer
Upgrade to netty 4.1.58.Final and evert "Ensure we don't register nat…
e486827 
…ive methods for classes that are included… (#31)" (#56)

Motivation:

Upgrade netty and revert changes which are not compatible with latest
netty version

Modification:

This reverts commit 43ae34f and
upgrades to netty 4.1.58.Final.

Result:

Use latest netty release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.3.Final
Development

Successfully merging this pull request may close these issues.

Dual IP stack problems when IOUring is initialized (even not used)
1 participant
@normanmaurer